Add max batches stopping criterion logic #2875
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2875 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 302 302
Lines 28296 28312 +16
=======================================
+ Hits 28200 28216 +16
Misses 96 96
Continue to review full report at Codecov.
|
| return False | ||
| elif self.max_iterations and num_pipelines >= self.max_iterations: | ||
| return False | ||
| elif self.max_batches and self._get_batch_number() > self.max_batches: |
There was a problem hiding this comment.
This logic would only be invoked for DefaultAlgorithm as max_iterations is set when it is None when using IterativeAlgorith.
jeremyliweishih
requested review from
ParthivNaresh,
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry,
eccabay and
freddyaboulton
bchen1116
left a comment
bchen1116
left a comment
There was a problem hiding this comment.
LGTM! Left some nits and a question for my own clarification
| elif mode == "long" and max_time: | ||
| max_batches = 999 # defers to stopping criterion | ||
| elif mode == "long" and max_time is None: | ||
| max_batches = 6 # corresponds to end of 'long' exploration phase |
There was a problem hiding this comment.
Can you explain where 4 and 6 come from?
There was a problem hiding this comment.
Batch 4 is the end of fast mode where we run our first ensembling run.
Batch 6 is the the part of long mode where we do our second ensembling round after running the exploration phase of long mode.
Fixes #2800.