-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add max batches stopping criterion logic #2875
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2875 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 302 302
Lines 28296 28312 +16
=======================================
+ Hits 28200 28216 +16
Misses 96 96
Continue to review full report at Codecov.
|
elapsed = time.time() - self._start | ||
if self.max_time and elapsed >= self.max_time: | ||
return False | ||
elif self.max_iterations and num_pipelines >= self.max_iterations: | ||
return False | ||
elif self.max_batches and self._get_batch_number() > self.max_batches: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic would only be invoked for DefaultAlgorithm
as max_iterations
is set when it is None when using IterativeAlgorith
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left some nits and a question for my own clarification
elif mode == "long" and max_time: | ||
max_batches = 999 # defers to stopping criterion | ||
elif mode == "long" and max_time is None: | ||
max_batches = 6 # corresponds to end of 'long' exploration phase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain where 4 and 6 come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Batch 4 is the end of fast mode where we run our first ensembling run.
Batch 6 is the the part of long mode where we do our second ensembling round after running the exploration phase of long mode.
Fixes #2800.