-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cmdstan to 0.28.0 #2880
Update cmdstan to 0.28.0 #2880
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2880 +/- ##
=======================================
+ Coverage 99.3% 99.7% +0.5%
=======================================
Files 302 302
Lines 28256 28256
=======================================
+ Hits 28046 28164 +118
+ Misses 210 92 -118
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for this!! 🙏
Thanks for taking care of this @ParthivNaresh ! One thing I noticed is that I don't see the code changes for version 0.0.8 in the cmdstan-builder repository. The latest version is 0.0.4 from August. Can you push up the 0.0.8 version? It's probably a good idea to tag the release branches in github as well so we can keep track of the history better? Also, should we just hardcode the cmdstan version installed via cmdstan-builder to 0.28.0 to avoid future breaking changes like this? |
Fixes: #2879
These changes involved a new release for
cmdstan-builder
located here, updating the install docs,setup.py
, as well as the GitHub workflows.