Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cmdstan to 0.28.0 #2880

Merged
merged 6 commits into from Oct 7, 2021
Merged

Update cmdstan to 0.28.0 #2880

merged 6 commits into from Oct 7, 2021

Conversation

ParthivNaresh
Copy link
Contributor

@ParthivNaresh ParthivNaresh commented Oct 7, 2021

Fixes: #2879

These changes involved a new release for cmdstan-builder located here, updating the install docs, setup.py, as well as the GitHub workflows.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #2880 (33e94df) into main (c540a7e) will increase coverage by 0.5%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2880     +/-   ##
=======================================
+ Coverage   99.3%   99.7%   +0.5%     
=======================================
  Files        302     302             
  Lines      28256   28256             
=======================================
+ Hits       28046   28164    +118     
+ Misses       210      92    -118     
Impacted Files Coverage Δ
evalml/tests/component_tests/test_utils.py 95.3% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.8% <100.0%> (ø)
evalml/tests/component_tests/test_components.py 98.9% <0.0%> (+0.3%) ⬆️
...ests/automl_tests/test_automl_search_regression.py 100.0% <0.0%> (+1.5%) ⬆️
...ponents/estimators/regressors/prophet_regressor.py 100.0% <0.0%> (+58.4%) ⬆️
...ml/tests/component_tests/test_prophet_regressor.py 100.0% <0.0%> (+89.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c540a7e...33e94df. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for this!! 🙏

@ParthivNaresh ParthivNaresh merged commit 322dcc0 into main Oct 7, 2021
@freddyaboulton
Copy link
Contributor

Thanks for taking care of this @ParthivNaresh !

One thing I noticed is that I don't see the code changes for version 0.0.8 in the cmdstan-builder repository. The latest version is 0.0.4 from August. Can you push up the 0.0.8 version? It's probably a good idea to tag the release branches in github as well so we can keep track of the history better?

Also, should we just hardcode the cmdstan version installed via cmdstan-builder to 0.28.0 to avoid future breaking changes like this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating the latest cmdstan version to support Nightlies and OS users for Prophet
3 participants