Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_all_estimators to account for Prophet in 3.9 #2892

Merged
merged 2 commits into from Oct 8, 2021

Conversation

ParthivNaresh
Copy link
Contributor

@ParthivNaresh ParthivNaresh commented Oct 8, 2021

Fixes #2893
Adds 1 to the estimator count when running tests for python 3.9

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #2892 (7eda352) into main (717075f) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2892   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        302     302           
  Lines      28312   28312           
=====================================
  Hits       28216   28216           
  Misses        96      96           
Impacted Files Coverage Δ
evalml/tests/pipeline_tests/test_pipelines.py 99.8% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 717075f...7eda352. Read the comment docs.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ParthivNaresh! 🙏

@ParthivNaresh ParthivNaresh merged commit ac55de2 into main Oct 8, 2021
@chukarsten chukarsten mentioned this pull request Oct 14, 2021
@freddyaboulton freddyaboulton deleted the Fix_Estimator_Count branch May 13, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update estimator count to include Prophet for 3.9
3 participants