Support Woodwork 0.8.2 #2909
Merged
Support Woodwork 0.8.2 #2909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2909 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 302 302
Lines 28412 28433 +21
=======================================
+ Hits 28319 28340 +21
Misses 93 93
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
2887-upgrade-to-ww-0.8.2
branch
2 times, most recently
from
de6e3bd
to
b1c334c
Compare
freddyaboulton
requested review from
chukarsten,
bchen1116,
dsherry,
angela97lin,
christopherbunn,
eccabay,
jeremyliweishih and
ParthivNaresh
bchen1116
approved these changes
Oct 15, 2021
docs/source/release_notes.rst
Outdated
| @@ -40,7 +43,7 @@ Release Notes | |||
| * Deleted scikit-learn ensembler :pr:`2819` | |||
| * ``IterativeAlgorithm`` now requires X, y, problem_type as required arguments as well as sampler_name, allowed_model_families, allowed_component_graphs, max_batches, and verbose as optional arguments :pr:`2854` | |||
| * Changed method names of ``fit_features`` and ``compute_final_component_features`` to ``fit_and_transform_all_but_final`` and ``transform_all_but_final`` in ``ComponentGraph``, and ``compute_estimator_features`` to ``transform_all_but_final`` in pipeline classes :pr:`2902` | |||
|
|
|||
| * Set the minimum allowed woodwork version to ``0.8.2``. | |||
There was a problem hiding this comment.
100% Can't believe I missed that!
| @@ -459,6 +459,9 @@ def test_delay_feature_transformer_woodwork_custom_overrides_returned_by_compone | |||
| X.ww.init(logical_types={0: logical_type}) | |||
| except (ww.exceptions.TypeConversionError, ValueError): | |||
| continue | |||
| if X.loc[:, 0].isna().all(): | |||
| # Casting the fourth and fifth dataframes to datetime will produce all NaNs | |||
freddyaboulton
force-pushed
the
2887-upgrade-to-ww-0.8.2
branch
from
b1c334c
to
9c2cea1
Compare
chukarsten
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
Looks good to me! I'm curious if we should care more about the case of casting the dataframe to Datetime to create all NaN. That doesn't seem to be consistent with the other override types. If you think it's important to follow up on, we can. I don't see any need here to block this, though!
| @@ -46,10 +51,10 @@ def _extract_month(col, encode_as_categories=False): | |||
| def _extract_day_of_week(col, encode_as_categories=False): | |||
There was a problem hiding this comment.
Filed this issue to refactor these two functions as they're the same.
freddyaboulton
force-pushed
the
2887-upgrade-to-ww-0.8.2
branch
from
9c2cea1
to
8943340
Compare
freddyaboulton
force-pushed
the
2887-upgrade-to-ww-0.8.2
branch
from
8943340
to
276a33f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2887, Fixes #2827
Perf tests are here. There is a slight drop in score for SeoulBikeData but I don't think it should hold up the upgrade.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.