Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select available columns in Select Columns Transformer #2944

Merged
merged 9 commits into from
Oct 21, 2021

Conversation

jeremyliweishih
Copy link
Collaborator

Fixes #2904, #2903.

The main issue was that because of cross validation, different columns would be created by the OHE but our feature selector (turned into a column selector) expects certain columns that doesn't exist. This PR fixes this by only selecting available columns. I will file a further issue to look into training FS on the entire feature set.

@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #2944 (cc7cb51) into main (8a0c4ea) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2944     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        302     302             
  Lines      28842   28850      +8     
=======================================
+ Hits       28751   28759      +8     
  Misses        91      91             
Impacted Files Coverage Δ
...elines/components/transformers/column_selectors.py 100.0% <100.0%> (ø)
...mponent_tests/test_column_selector_transformers.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a0c4ea...cc7cb51. Read the comment docs.

@jeremyliweishih jeremyliweishih marked this pull request as ready for review October 21, 2021 18:18
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some nit-picky comments that would be good to address before merging but nothing major.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @jeremyliweishih !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultAlgorithm errors out during cross validation with encoder and feature selection interaction
3 participants