-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Select available columns in Select Columns Transformer
#2944
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2944 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 302 302
Lines 28842 28850 +8
=======================================
+ Hits 28751 28759 +8
Misses 91 91
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left some nit-picky comments that would be good to address before merging but nothing major.
evalml/tests/component_tests/test_column_selector_transformers.py
Outdated
Show resolved
Hide resolved
evalml/tests/component_tests/test_column_selector_transformers.py
Outdated
Show resolved
Hide resolved
…valml into js_2903_ignore_missing_columns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @jeremyliweishih !
Fixes #2904, #2903.
The main issue was that because of cross validation, different columns would be created by the OHE but our feature selector (turned into a column selector) expects certain columns that doesn't exist. This PR fixes this by only selecting available columns. I will file a further issue to look into training FS on the entire feature set.