Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update daily min temperatures link for demo dataset #3023

Merged
merged 9 commits into from Nov 9, 2021
Merged

Conversation

gsheni
Copy link
Contributor

@gsheni gsheni commented Nov 8, 2021

@gsheni gsheni changed the title Update weather.py Draft: Update weather.py Nov 8, 2021
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #3023 (0b7293b) into main (75b07c7) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3023     +/-   ##
=======================================
+ Coverage   99.7%   99.8%   +0.1%     
=======================================
  Files        312     312             
  Lines      30143   30162     +19     
=======================================
+ Hits       30047   30073     +26     
+ Misses        96      89      -7     
Impacted Files Coverage Δ
evalml/data_checks/target_leakage_data_check.py 100.0% <ø> (ø)
evalml/demos/weather.py 100.0% <100.0%> (+63.7%) ⬆️
evalml/tests/conftest.py 98.4% <100.0%> (+0.1%) ⬆️
evalml/tests/demo_tests/test_datasets.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75b07c7...0b7293b. Read the comment docs.

@gsheni gsheni changed the title Draft: Update weather.py Update daily min temperatures link for demo dataset Nov 8, 2021
@gsheni gsheni requested a review from a team November 8, 2021 23:04
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this, looks good! 🙏

Can we remove this from setup.py as well?

The lines:

    data_files=[('evalml/tests/data', ['evalml/tests/data/tips.csv',
                                       'evalml/tests/data/titanic.csv',
                                       'evalml/tests/data/churn.csv',
                                       'evalml/tests/data/fraud_transactions.csv.gz']),
                ('evalml/demos/data', ['evalml/demos/data/daily-min-temperatures.csv'])],

@gsheni
Copy link
Contributor Author

gsheni commented Nov 8, 2021

@angela97lin done:
80a2805

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gsheni !

setup.py Show resolved Hide resolved
@gsheni gsheni merged commit ec4e563 into main Nov 9, 2021
@gsheni gsheni deleted the add_daily_min_link branch November 9, 2021 14:50
@chukarsten chukarsten mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update daily min weather dataset with new link
3 participants