Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data_check_name attribute to each data check action #3034

Merged
merged 8 commits into from Nov 15, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #2179.

@angela97lin angela97lin self-assigned this Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #3034 (751e2fe) into main (8b04d4b) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3034     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        312     312             
  Lines      30229   30238      +9     
=======================================
+ Hits       30139   30148      +9     
  Misses        90      90             
Impacted Files Coverage Δ
evalml/data_checks/highly_null_data_check.py 100.0% <ø> (ø)
evalml/data_checks/id_columns_data_check.py 100.0% <ø> (ø)
evalml/data_checks/invalid_targets_data_check.py 100.0% <ø> (ø)
evalml/data_checks/no_variance_data_check.py 100.0% <ø> (ø)
evalml/data_checks/outliers_data_check.py 100.0% <ø> (ø)
evalml/data_checks/sparsity_data_check.py 100.0% <ø> (ø)
...alml/data_checks/target_distribution_data_check.py 100.0% <ø> (ø)
evalml/data_checks/target_leakage_data_check.py 100.0% <ø> (ø)
evalml/data_checks/uniqueness_data_check.py 100.0% <ø> (ø)
...s/data_checks_tests/test_highly_null_data_check.py 100.0% <ø> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b04d4b...751e2fe. Read the comment docs.

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@angela97lin angela97lin merged commit 5242358 into main Nov 15, 2021
@chukarsten chukarsten mentioned this pull request Nov 29, 2021
@angela97lin angela97lin deleted the 2179_data_check_action_names branch January 11, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataChecks: ability to tell which actions came from which data checks
2 participants