Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Featuretools Primitives in DateTimeFeaturizer #3081

Merged
merged 5 commits into from
Nov 19, 2021

Conversation

jeremyliweishih
Copy link
Collaborator

Fixes #2916.

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #3081 (ea55047) into main (26d38a4) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3081     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        312     312             
  Lines      30433   30437      +4     
=======================================
+ Hits       30343   30347      +4     
  Misses        90      90             
Impacted Files Coverage Δ
.../transformers/preprocessing/datetime_featurizer.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d38a4...ea55047. Read the comment docs.

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Short and sweet, nice work!

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jeremyliweishih !

@jeremyliweishih jeremyliweishih merged commit 72b8048 into main Nov 19, 2021
@chukarsten chukarsten mentioned this pull request Nov 29, 2021
@freddyaboulton freddyaboulton deleted the js_2916_dtf_primitives branch May 13, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify and reach feature parity with DatetimeFeaturizer and featuretools primitives
3 participants