Repository navigation
Return details from TargetDistributionDataCheck as floats rather string - #3085
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3085 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 313 313
Lines 30468 30470 +2
=======================================
+ Hits 30378 30380 +2
Misses 90 90
Continue to review full report at Codecov.
|
angela97lin
commented
Nov 22, 2021
| return results | ||
|
|
||
|
|
||
| def _detect_log_distribution_helper(y): |
Contributor
Author
There was a problem hiding this comment.
Moving mathy-implementation chunk into helper method to make validate easier to read!
angela97lin
marked this pull request as ready for review
November 22, 2021 16:07
angela97lin
requested review from
ParthivNaresh,
bchen1116,
chukarsten,
dsherry,
eccabay,
freddyaboulton and
jeremyliweishih
November 22, 2021 16:07
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2943. I chose not to keep the string representation and moved the calculations into a separate helper method, but open to discussion if we feel like the string representation is helpful in addition to the float values.