-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return details from TargetDistributionDataCheck
as floats rather string
#3085
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3085 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 313 313
Lines 30468 30470 +2
=======================================
+ Hits 30378 30380 +2
Misses 90 90
Continue to review full report at Codecov.
|
@@ -142,3 +126,26 @@ def validate(self, X, y): | |||
) | |||
|
|||
return results | |||
|
|||
|
|||
def _detect_log_distribution_helper(y): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving mathy-implementation chunk into helper method to make validate
easier to read!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
Closes #2943. I chose not to keep the string representation and moved the calculations into a separate helper method, but open to discussion if we feel like the string representation is helpful in addition to the float values.