Move out indices information from output of HighlyNullDataCheck's validate() method#3092
Merged
angela97lin merged 10 commits intomainfrom Dec 6, 2021
Merged
Move out indices information from output of HighlyNullDataCheck's validate() method#3092angela97lin merged 10 commits intomainfrom
HighlyNullDataCheck's validate() method#3092angela97lin merged 10 commits intomainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3092 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 313 313
Lines 30585 30603 +18
=======================================
+ Hits 30495 30513 +18
Misses 90 90
Continue to review full report at Codecov.
|
angela97lin
requested review from
ParthivNaresh,
bchen1116,
chukarsten,
dsherry,
eccabay and
freddyaboulton
freddyaboulton
approved these changes
Dec 3, 2021
Contributor
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Thanks @angela97lin !
chukarsten
approved these changes
Dec 3, 2021
Contributor
chukarsten
left a comment
chukarsten
left a comment
There was a problem hiding this comment.
Awesome, thanks for the bonus refactor of the common dataset. This is the way.
| highly_null_data_check_name = HighlyNullDataCheck.name | ||
|
|
||
|
|
||
| @pytest.fixture |
Contributor
There was a problem hiding this comment.
You're the best! Thanks!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3000