Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move out indices information from output of HighlyNullDataCheck's validate() method #3092

Merged
merged 10 commits into from
Dec 6, 2021
Merged

Move out indices information from output of HighlyNullDataCheck's validate() method #3092

merged 10 commits into from
Dec 6, 2021

Conversation

angela97lin
Copy link
Contributor

Closes #3000

@angela97lin angela97lin self-assigned this Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021 •
edited
Loading

Codecov Report

Merging #3092 (3dcc052) into main (cc3c699) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3092     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        313     313             
  Lines      30585   30603     +18     
=======================================
+ Hits       30495   30513     +18     
  Misses        90      90
Impacted Files Coverage Δ
evalml/tests/data_checks_tests/test_data_checks.py 100.0% <ø> (ø)
evalml/data_checks/highly_null_data_check.py 100.0% <100.0%> (ø)
...s/data_checks_tests/test_highly_null_data_check.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3c699...3dcc052. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review December 2, 2021 21:43
freddyaboulton
freddyaboulton approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @angela97lin !

chukarsten
chukarsten approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the bonus refactor of the common dataset. This is the way.

evalml/tests/data_checks_tests/test_highly_null_data_check.py
@@ -13,6 +13,17 @@
highly_null_data_check_name = HighlyNullDataCheck.name


@pytest.fixture
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're the best! Thanks!

eccabay
eccabay approved these changes Dec 3, 2021
View reviewed changes
Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

docs/source/release_notes.rst Outdated Show resolved Hide resolved
evalml/data_checks/highly_null_data_check.py Outdated Show resolved Hide resolved
@angela97lin angela97lin merged commit b786c54 into main Dec 6, 2021
@angela97lin angela97lin deleted the 3000_data_health_refactor branch December 6, 2021 18:59
@angela97lin angela97lin restored the 3000_data_health_refactor branch December 6, 2021 18:59
@angela97lin angela97lin deleted the 3000_data_health_refactor branch December 6, 2021 18:59
@chukarsten chukarsten mentioned this pull request Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@eccabay eccabay eccabay approved these changes

@chukarsten chukarsten chukarsten approved these changes

@ParthivNaresh ParthivNaresh Awaiting requested review from ParthivNaresh

@bchen1116 bchen1116 Awaiting requested review from bchen1116

@dsherry dsherry Awaiting requested review from dsherry

Assignees

@angela97lin angela97lin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataCheckActions user guide formatting
4 participants
@angela97lin @freddyaboulton @eccabay @chukarsten