Clean up and refactor InvalidTargetDataCheck#3122
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3122 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 315 315
Lines 30664 30684 +20
=======================================
+ Hits 30573 30593 +20
Misses 91 91
Continue to review full report at Codecov.
|
freddyaboulton
left a comment
There was a problem hiding this comment.
Thanks @angela97lin ! Looks good to me!
chukarsten
left a comment
There was a problem hiding this comment.
Looks good to me. Left some minor comments but feel free to ignore.
| from .data_check_message_type import DataCheckMessageType | ||
| from .default_data_checks import DefaultDataChecks | ||
| from .invalid_targets_data_check import InvalidTargetDataCheck | ||
| from .invalid_target_data_check import InvalidTargetDataCheck |
There was a problem hiding this comment.
I'm not sure, but would this count as a breaking change?
There was a problem hiding this comment.
Oo good call! I'd say it's safer to add it as a breaking change since we're changing the module name. Adding to release notes, thanks!
Closes #1741
This PR adds a more in-depth docstring detailing what
InvalidTargetDataCheckchecks, and breaks up each of the different checks into their own helper methods.