Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and refactor InvalidTargetDataCheck #3122

Merged
merged 7 commits into from
Dec 6, 2021

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Dec 3, 2021

Closes #1741

This PR adds a more in-depth docstring detailing what InvalidTargetDataCheck checks, and breaks up each of the different checks into their own helper methods.

@angela97lin angela97lin self-assigned this Dec 3, 2021
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #3122 (baecc19) into main (b9d4cb6) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3122     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        315     315             
  Lines      30664   30684     +20     
=======================================
+ Hits       30573   30593     +20     
  Misses        91      91             
Impacted Files Coverage Δ
...ata_checks_tests/test_invalid_target_data_check.py 100.0% <ø> (ø)
evalml/data_checks/__init__.py 100.0% <100.0%> (ø)
evalml/data_checks/default_data_checks.py 100.0% <100.0%> (ø)
evalml/data_checks/invalid_target_data_check.py 100.0% <100.0%> (ø)
..._tests/test_data_checks_and_actions_integration.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9d4cb6...baecc19. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review December 3, 2021 21:56
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @angela97lin ! Looks good to me!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Left some minor comments but feel free to ignore.

from .invalid_targets_data_check import InvalidTargetDataCheck
from .invalid_target_data_check import InvalidTargetDataCheck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but would this count as a breaking change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oo good call! I'd say it's safer to add it as a breaking change since we're changing the module name. Adding to release notes, thanks!

@angela97lin angela97lin merged commit 30b2a6a into main Dec 6, 2021
@angela97lin angela97lin deleted the 1741_invalid_target_dc_cleanup branch December 6, 2021 23:40
@chukarsten chukarsten mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidTargetDataCheck Cleanup
4 participants