-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark which tests should be skipped for python 3.9 #3133
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3133 +/- ##
=======================================
- Coverage 99.7% 99.7% -0.0%
=======================================
Files 317 317
Lines 30711 30718 +7
=======================================
+ Hits 30607 30610 +3
- Misses 104 108 +4
Continue to review full report at Codecov.
|
Passing nightlies here: https://github.com/alteryx/evalml/runs/4459458578?check_suite_focus=true They are all from this commit |
skip_39 = pytest.mark.skip(reason="Test dependency not supported in python 3.9") | ||
for item in items: | ||
if "skip_if_39" in item.keywords: | ||
item.add_marker(skip_39) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's coverage in the passing windows/linux 3.9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 thank you
Pull Request Description
Third time's the charm 😅
Fix broken nightlies by marking tests as being skipped for 3.9.
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.