Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark which tests should be skipped for python 3.9 #3133

merged 4 commits into from
Dec 8, 2021


Copy link

Pull Request Description

Third time's the charm 馃槄

Fix broken nightlies by marking tests as being skipped for 3.9.

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #3133 (dddd54b) into main (3aa1b36) will decrease coverage by 0.1%.
The diff coverage is 60.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3133     +/-   ##
- Coverage   99.7%   99.7%   -0.0%     
  Files        317     317             
  Lines      30711   30718      +7     
+ Hits       30607   30610      +3     
- Misses       104     108      +4     
Impacted Files Coverage 螖
evalml/tests/ 96.0% <33.4%> (-0.5%) 猬囷笍
...alml/tests/component_tests/ 100.0% <100.0%> (酶)
...tests/component_tests/ 100.0% <100.0%> (酶) 100.0% <100.0%> (酶)
.../tests/pipeline_tests/ 99.8% <100.0%> (+0.1%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3aa1b36...dddd54b. Read the comment docs.

Copy link
Contributor Author

freddyaboulton commented Dec 8, 2021

@freddyaboulton freddyaboulton added the blocker An issue blocking a release. label Dec 8, 2021
@freddyaboulton freddyaboulton self-assigned this Dec 8, 2021
@freddyaboulton freddyaboulton marked this pull request as ready for review December 8, 2021 17:06
skip_39 = pytest.mark.skip(reason="Test dependency not supported in python 3.9")
for item in items:
if "skip_if_39" in item.keywords:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's coverage in the passing windows/linux 3.9

Copy link

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃檹 thank you

@freddyaboulton freddyaboulton merged commit eb1e3e0 into main Dec 8, 2021
@freddyaboulton freddyaboulton deleted the fix-windows-3.9-tests branch December 8, 2021 19:30
@chukarsten chukarsten mentioned this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
blocker An issue blocking a release.
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants