Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string support for data check action code #3167

Merged
merged 10 commits into from
Dec 23, 2021

Conversation

bchen1116
Copy link
Contributor

fix #1904

@bchen1116 bchen1116 self-assigned this Dec 21, 2021
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #3167 (5cb62d4) into main (2b7c4a8) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3167     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        320     322      +2     
  Lines      31029   31070     +41     
=======================================
+ Hits       30924   30965     +41     
  Misses       105     105             
Impacted Files Coverage Δ
evalml/data_checks/data_check_action.py 100.0% <100.0%> (ø)
evalml/data_checks/data_check_action_code.py 100.0% <100.0%> (ø)
evalml/data_checks/utils.py 100.0% <100.0%> (ø)
.../tests/data_checks_tests/test_data_check_action.py 100.0% <100.0%> (ø)
evalml/tests/data_checks_tests/test_utils.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b7c4a8...5cb62d4. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for taking this on! 🙏 Just left a few really nit-picky comments :)

evalml/data_checks/utils.py Outdated Show resolved Hide resolved
evalml/tests/data_checks_tests/test_utils.py Show resolved Hide resolved
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@bchen1116 bchen1116 merged commit 97045bc into main Dec 23, 2021
@chukarsten chukarsten mentioned this pull request Jan 6, 2022
@freddyaboulton freddyaboulton deleted the bc_1904_data_check_actions branch May 13, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make data check action codes accessible via strings
3 participants