Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting gap #3198

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Reverting gap #3198

merged 2 commits into from
Jan 7, 2022

Conversation

ParthivNaresh
Copy link
Contributor

Reverting gap PR until aml can enforce uniform freq


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #3198 (d16f53b) into main (5a8c1c8) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3198     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        326     326             
  Lines      31444   31390     -54     
=======================================
- Hits       31340   31286     -54     
  Misses       104     104             
Impacted Files Coverage Δ
evalml/demos/weather.py 100.0% <ø> (ø)
evalml/tests/demo_tests/test_datasets.py 100.0% <ø> (ø)
evalml/pipelines/time_series_pipeline_base.py 100.0% <100.0%> (ø)
evalml/tests/automl_tests/test_engine_base.py 100.0% <100.0%> (ø)
evalml/tests/conftest.py 96.3% <100.0%> (ø)
.../tests/pipeline_tests/test_time_series_pipeline.py 99.8% <100.0%> (-<0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8c1c8...d16f53b. Read the comment docs.

@ParthivNaresh ParthivNaresh requested review from freddyaboulton and chukarsten and removed request for freddyaboulton January 7, 2022 19:53
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @ParthivNaresh !

@ParthivNaresh ParthivNaresh merged commit a982453 into main Jan 7, 2022
@freddyaboulton freddyaboulton deleted the revert_gap branch May 13, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants