Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest dependency yaml to remove comment about keeping branch and set delete-branch to true #3212

Merged
merged 28 commits into from Jan 13, 2022

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Jan 11, 2022

Sample PR looks like: #3213. I closed the PR but don't see the branch auto-delete. :( According to this issue:

When delete-branch is set to true the action will delete the branch in two situations:

If the action is closing the pull request itself (because there is no longer any diff)
If the branch remains in the remote, but there are no further changes. In this case, most likely it has been left undeleted after merging.
Your expectation seems to be that the branch should be deleted immediately after merge, but that's not how it works. The action will find and delete it next time it runs.

@angela97lin angela97lin self-assigned this Jan 11, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #3212 (7f00798) into main (76661ac) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3212   +/-   ##
=====================================
  Coverage   99.8%   99.8%           
=====================================
  Files        326     326           
  Lines      31395   31395           
=====================================
  Hits       31304   31304           
  Misses        91      91           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76661ac...7f00798. Read the comment docs.

branch: latest-dep-update
branch-suffix: short-commit-hash
delete-branch: true
base: main
reviewers: angela97lin, dsherry, jeremyliweishih, freddyaboulton, bchen1116, chukarsten, ParthivNaresh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reviewers: angela97lin, dsherry, jeremyliweishih, freddyaboulton, bchen1116, chukarsten, ParthivNaresh
reviewers: machineAYX

workflow_dispatch:
workflow_run:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen this work on repos yet, so I was waiting until it did before adding it here. In the meantime, I would suggest keeping the schedule

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh saddo. Okay, good to know!

@angela97lin angela97lin merged commit 0bae399 into main Jan 13, 2022
@angela97lin angela97lin deleted the update_latest_dep_contributing branch January 13, 2022 07:06
@chukarsten chukarsten mentioned this pull request Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants