-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update InvalidTargetDataCheck to validate time series regression problems #3251
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3251 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 326 326
Lines 31467 31476 +9
=======================================
+ Hits 31376 31385 +9
Misses 91 91
Continue to review full report at Codecov.
|
b2a7952
to
8f23f0d
Compare
@@ -527,7 +530,10 @@ def test_invalid_target_data_check_regression_problem_nonnumeric_data(): | |||
) == {"warnings": [], "errors": [], "actions": []} | |||
|
|||
|
|||
def test_invalid_target_data_check_multiclass_problem_binary_data(): | |||
@pytest.mark.parametrize( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to the issue but just adding coverage for time series classification. Same below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for the quick fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks!
Pull Request Description
Fixes #3249
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.