Update InvalidTargetDataCheck to validate time series regression problems #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freddyaboulton
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3251 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 326 326
Lines 31467 31476 +9
=======================================
+ Hits 31376 31385 +9
Misses 91 91
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
3249-invalid-target-check-ts
branch
from
b2a7952
to
8f23f0d
Compare
freddyaboulton
requested review from
angela97lin,
bchen1116,
eccabay,
christopherbunn,
chukarsten,
dsherry,
jeremyliweishih and
ParthivNaresh
and removed request for
angela97lin and
bchen1116
freddyaboulton
commented
Jan 18, 2022
| @@ -527,7 +530,10 @@ def test_invalid_target_data_check_regression_problem_nonnumeric_data(): | |||
| ) == {"warnings": [], "errors": [], "actions": []} | |||
|
|
|||
|
|
|||
| def test_invalid_target_data_check_multiclass_problem_binary_data(): | |||
| @pytest.mark.parametrize( | |||
There was a problem hiding this comment.
Unrelated to the issue but just adding coverage for time series classification. Same below.
chukarsten
approved these changes
Jan 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #3249
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.