Ensure prediction explanations are json-serializable #3262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccabay
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3262 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 326 326
Lines 31477 31496 +19
=======================================
+ Hits 31386 31405 +19
Misses 91 91
Continue to review full report at Codecov.
|
eccabay
requested review from
angela97lin,
bchen1116,
christopherbunn,
chukarsten,
dsherry and
freddyaboulton
jeremyliweishih
approved these changes
Jan 20, 2022
Collaborator
jeremyliweishih
left a comment
jeremyliweishih
left a comment
There was a problem hiding this comment.
Might need some changes to the test but should be good after pending discussion!
evalml/tests/model_understanding_tests/prediction_explanations_tests/test_explainers.py
Outdated
Show resolved
Hide resolved
freddyaboulton
approved these changes
Jan 20, 2022
Contributor
freddyaboulton
left a comment
freddyaboulton
left a comment
There was a problem hiding this comment.
Thank you for the fix @eccabay !!
evalml/tests/model_understanding_tests/prediction_explanations_tests/test_explainers.py
Outdated
Show resolved
Hide resolved
evalml/model_understanding/prediction_explanations/_user_interface.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2366
Since the writing of this issue, a couple other data types also caused issues, so I added those as well.