Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure prediction explanations are json-serializable #3262

Merged
merged 10 commits into from
Jan 20, 2022

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Jan 19, 2022

Closes #2366

Since the writing of this issue, a couple other data types also caused issues, so I added those as well.

@eccabay eccabay changed the title 2366 explanation json Ensure prediction explanations are json-serializable Jan 19, 2022
@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #3262 (33e4bd4) into main (992b877) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3262     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        326     326             
  Lines      31477   31496     +19     
=======================================
+ Hits       31386   31405     +19     
  Misses        91      91             
Impacted Files Coverage Δ
...tanding/prediction_explanations/_user_interface.py 100.0% <100.0%> (ø)
...s/prediction_explanations_tests/test_explainers.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 992b877...33e4bd4. Read the comment docs.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might need some changes to the test but should be good after pending discussion!

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @eccabay !!

@eccabay eccabay merged commit a8d0dce into main Jan 20, 2022
@eccabay eccabay deleted the 2366_explanation-json branch January 20, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prediction explanations cannot be written to json when target is of type bool
3 participants