Upgrade nbconvert req; remove jinja2 dependency #3411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3411 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 329 329
Lines 32406 32406
=====================================
Hits 32277 32277
Misses 129 129 Continue to review full report at Codecov.
|
| @@ -1,11 +1,10 @@ | |||
| jinja2 == 3.0.3 | |||
There was a problem hiding this comment.
might need to pin this still until jinja resolves, still getting: ImportError: cannot import name 'environmentfilter' from 'jinja2' (/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/jinja2/__init__.py)
There was a problem hiding this comment.
looks like an old version of sphinx
|
Has this error come up before? Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/ipykernel/kernelbase.py", line 1200, in _at_shutdown
await self._progressively_terminate_all_children()
GeneratorExit
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/ipykernel/kernelbase.py", line 297, in process_control
await result
File "/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/ipykernel/kernelbase.py", line 836, in shutdown_request
await self._at_shutdown()
File "/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/ipykernel/kernelbase.py", line 1206, in _at_shutdown
self.session.send(
File "/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/jupyter_client/session.py", line 853, in send
stream.send_multipart(to_send, copy=copy)
File "/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/ipykernel/iostream.py", line 285, in send_multipart
return self.io_thread.send_multipart(*args, **kwargs)
File "/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/ipykernel/iostream.py", line 225, in send_multipart
self.schedule(lambda : self._really_send(*args, **kwargs))
File "/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/ipykernel/iostream.py", line 218, in schedule
f()
File "/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/ipykernel/iostream.py", line 225, in <lambda>
self.schedule(lambda : self._really_send(*args, **kwargs))
File "/home/docs/checkouts/readthedocs.org/user_builds/feature-labs-inc-evalml/envs/3411/lib/python3.8/site-packages/ipykernel/iostream.py", line 233, in _really_send
self.socket.send_multipart(msg, *args, **kwargs)
AttributeError: 'NoneType' object has no attribute 'send_multipart' |
docs/source/conf.py
Outdated
| @@ -284,7 +284,7 @@ def setup(app): | |||
| shutil.copy("disable-warnings.py", "/home/docs/.ipython/profile_default/startup/") | |||
| shutil.copy("set-headers.py", "/home/docs/.ipython/profile_default/startup") | |||
| app.add_domain(PatchedPythonDomain, override=True) | |||
| app.add_javascript( | |||
| app.add_js_file( | |||
| "https://cdnjs.cloudflare.com/ajax/libs/require.js/2.1.10/require.min.js" | |||
| ) | |||
| app.add_stylesheet("style.css") | |||
There was a problem hiding this comment.
one last warning here from the build:
WARNING: while setting up extension conf.py: The app.add_stylesheet() is deprecated. Please use app.add_css_file() instead.
jeremyliweishih
approved these changes
Mar 28, 2022
|
@chukarsten ok to merge this in? |
|
Thanks @rwedge !! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3403