Skip to content

Update pyproject.toml to correctly specify the data filepaths - #3967

Merged
gsheni merged 16 commits into
mainfrom
fix_package_data
Jan 30, 2023
Merged

gsheni merged 16 commits into
mainfrom
fix_package_data

Conversation

@gsheni

@gsheni gsheni commented Jan 30, 2023 •

Copy link
Copy Markdown
Contributor
  • The install test workflow packages evalml (creates whl/tar.gz file), install that whl/tar.gz, and tries to import the datasets (to make sure it is distributed with evalml).
  • The commands in meta.yaml also try to import the datasets (to make sure conda has the files).

@gsheni gsheni self-assigned this Jan 30, 2023
@gsheni
gsheni requested a review from chukarsten January 30, 2023 19:16
@gsheni gsheni changed the title Update pyproject.toml Update pyproject.toml to correctly specify the data filepaths Jan 30, 2023
@gsheni
gsheni marked this pull request as ready for review January 30, 2023 19:19
@codecov

codecov Bot commented Jan 30, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #3967 (6095d35) into main (c848b80) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #3967   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        347     347           
  Lines      36790   36790           
=====================================
  Hits       36670   36670           
  Misses       120     120           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread .github/meta.yaml Outdated
@gsheni
gsheni enabled auto-merge (squash) January 30, 2023 20:13
Comment thread pyproject.toml Outdated
@gsheni
gsheni merged commit 9b4ff1b into main Jan 30, 2023
@gsheni
gsheni deleted the fix_package_data branch January 30, 2023 21:05
@chukarsten chukarsten mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants