Use black to format pipeline code#4005
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4005 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 347 347
Lines 36914 36954 +40
=======================================
+ Hits 36793 36833 +40
Misses 121 121
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jeremyliweishih
commented
Feb 16, 2023
| - colorama >=0.4.4 | ||
| - cloudpickle >=1.5.0 | ||
| - click >=7.1.2 | ||
| - click>=8.0.0 |
Collaborator
Author
There was a problem hiding this comment.
needed for black.
jeremyliweishih
requested review from
christopherbunn,
chukarsten,
eccabay and
fjlanasa
christopherbunn
approved these changes
Feb 16, 2023
Contributor
christopherbunn
left a comment
christopherbunn
left a comment
There was a problem hiding this comment.
Small q but otherwise LGTM
| "parameters={'Imputer':{'categorical_impute_strategy': 'most_frequent', 'numeric_impute_strategy': 'mean', 'boolean_impute_strategy': 'most_frequent', 'categorical_fill_value': None, 'numeric_fill_value': None, 'boolean_fill_value': None}, " | ||
| "'Random Forest Classifier':{'n_estimators': 100, 'max_depth': 6, 'n_jobs': -1}}, random_seed=0)" | ||
| "'Random Forest Classifier':{'n_estimators': 100, 'max_depth': 6, 'n_jobs': -1}}, random_seed=0)", | ||
| mode=black.Mode(target_versions={black.TargetVersion.PY39}, line_length=88), |
Contributor
There was a problem hiding this comment.
Is line_length=88 arbitrary? Wondering if it's worth making it a param or global variable.
Collaborator
Author
There was a problem hiding this comment.
It's what we have in our black config. Let me see how I can clean it up!
chukarsten
approved these changes
Feb 17, 2023
eccabay
approved these changes
Feb 17, 2023
Contributor
eccabay
left a comment
eccabay
left a comment
There was a problem hiding this comment.
Looks good pending pulling out the line_length=88 somehow!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4004.