Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement generate_pipeline_example #4023

Merged
merged 11 commits into from
Feb 24, 2023
Merged

Implement generate_pipeline_example #4023

merged 11 commits into from
Feb 24, 2023

Conversation

jeremyliweishih
Copy link
Contributor

Fixes #4012.

@codecov
Copy link

codecov bot commented Feb 21, 2023 •
edited

Codecov Report

Merging #4023 (c802cdc) into main (5ab965f) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4023     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      37200   37242     +42     
=======================================
+ Hits       37079   37121     +42     
  Misses       121     121
Impacted Files Coverage Δ
evalml/pipelines/utils.py 99.6% <100.0%> (+0.1%) ⬆️
evalml/tests/pipeline_tests/test_pipeline_utils.py 99.8% <100.0%> (+0.1%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jeremyliweishih jeremyliweishih marked this pull request as ready for review February 22, 2023 16:40
christopherbunn
christopherbunn approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@christopherbunn christopherbunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion for testing string subs but otherwise LGTM

evalml/tests/pipeline_tests/test_pipeline_utils.py Show resolved Hide resolved
tamargrey
tamargrey approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm--Nice work!

@jeremyliweishih jeremyliweishih merged commit b824d26 into main Feb 24, 2023
@jeremyliweishih jeremyliweishih deleted the js_4012_pipeline_example branch February 24, 2023 20:59
@chukarsten chukarsten mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherbunn christopherbunn christopherbunn approved these changes

@tamargrey tamargrey tamargrey approved these changes

@eccabay eccabay Awaiting requested review from eccabay

@fjlanasa fjlanasa Awaiting requested review from fjlanasa

Assignees

@jeremyliweishih jeremyliweishih

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate reproducible pipeline example
3 participants
@jeremyliweishih @christopherbunn @tamargrey