-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_prediction_intervals()
at the pipeline level
#4052
Conversation
67fcf6b
to
05f6028
Compare
Codecov Report
@@ Coverage Diff @@
## main #4052 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 349 349
Lines 37476 37514 +38
=======================================
+ Hits 37358 37396 +38
Misses 118 118
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some considerations while reviewing:
@@ -172,6 +175,7 @@ def get_prediction_intervals( | |||
nsimulations=X.shape[0], | |||
repetitions=400, | |||
anchor="end", | |||
random_state=self.parameters["random_state"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up having to set the random_state
here to the random_seed
, otherwise we would not get deterministic results. I wonder if this needs to be updated for all of the sktime-based estimators?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be good to file!
NO_PREDS_PI_ESTIMATORS = [ | ||
ModelFamily.ARIMA, | ||
ModelFamily.EXPONENTIAL_SMOOTHING, | ||
ModelFamily.PROPHET, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the estimators where we currently can't use the recomposed predictions to calculate the prediction intervals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just a couple small fixes. We should also file an issue to update the user guide to use the pipeline level implementation since its more convinient!
@jeremyliweishih Updated the timeseries docs to use the pipeline implementation! |
3ef4cb5
to
8640605
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Resolves #4060
Adds
get_prediction_intervals()
at the pipeline level, which runsinverse_transform()
before returning results.