Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont allow knn as boolean impute strategy #4058

Merged
merged 3 commits into from
Mar 10, 2023
Merged

Conversation

tamargrey
Copy link
Contributor

closes #4057

Removes "knn" from boolean_impute_strategy in the Imputer component and stops accounting for boolean data in the KNNImputer component.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #4058 (5ed40c3) into main (f509df4) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4058     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        349     349             
  Lines      37509   37476     -33     
=======================================
- Hits       37391   37358     -33     
  Misses       118     118             
Impacted Files Coverage Δ
evalml/tests/pipeline_tests/test_pipelines.py 99.9% <ø> (ø)
...elines/components/transformers/imputers/imputer.py 100.0% <100.0%> (ø)
...es/components/transformers/imputers/knn_imputer.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_imputer.py 100.0% <100.0%> (ø)
evalml/tests/component_tests/test_knn_imputer.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamargrey tamargrey marked this pull request as ready for review March 8, 2023 19:15
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamargrey tamargrey merged commit 4c0ec4d into main Mar 10, 2023
@tamargrey tamargrey deleted the remove-knn-bool-imputing branch March 10, 2023 15:23
@chukarsten chukarsten mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use KNN Imputer for boolean data
3 participants