Fix pipeline example erroring out on DFS #4059

jeremyliweishih · 2023-03-08T20:15:16Z

This PR removes the features parameters in the pipeline example when DFS is present and adds in the features as an optional argument.

codecov · 2023-03-08T20:22:00Z

Codecov Report

Merging #4059 (f09ff18) into main (1412fc3) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4059     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      37514   37559     +45     
=======================================
+ Hits       37396   37441     +45     
  Misses       118     118

Impacted Files	Coverage Δ
...nents/transformers/preprocessing/stl_decomposer.py	`100.0% <ø> (ø)`
evalml/pipelines/pipeline_base.py	`98.5% <ø> (ø)`
evalml/pipelines/utils.py	`99.6% <100.0%> (+0.1%)`	⬆️
evalml/tests/pipeline_tests/test_pipeline_utils.py	`99.8% <100.0%> (+0.1%)`	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jeremyliweishih · 2023-03-08T20:55:39Z

evalml/pipelines/pipeline_base.py

@@ -709,6 +709,8 @@ def repr_component(parameters):
        parameters_repr = ", ".join(
            [
                f"'{component}':{{{repr_component(parameters)}}}"
+                if component != "DFS Transformer"


Need to exclude the DFS Transformer since the __repr__ of a feature is not executable.

could this ever be problematic if there's separate Numeric Pipeline vs Categorical Pipeline? I forget if dfs transformer comes before we split pipelines, though, so I definitely might not have all the info here.

Same question goes for has_dfs = "DFS Transformer" in element.component_graph.compute_order below

the DFS Transformer always comes first so I don't believe it should be a problem (and it'll always be named DFS Transformer

jeremyliweishih · 2023-03-08T20:56:10Z

evalml/pipelines/utils.py

-df = pd.read_csv(PATH_TO_TRAIN)
-y_train = df[TARGET]
-X_train = df.drop(TARGET, axis=1)
+df = ww.deserialize.from_disk(PATH_TO_TRAIN)


moved to use woodwork serialization to keep feature origin info.

jeremyliweishih · 2023-03-08T20:57:29Z

evalml/tests/pipeline_tests/test_pipeline_utils.py

+
+    X_train = pd.DataFrame(X_train)
+    X_train.columns = X_train.columns.astype(str)
+    es = ft.EntitySet()


I can split the DFS/non-DFS case as well but I thought that the DFS case covers all the edge cases already so I kept it like this for now. LMK what you all think.

I tihnk it's fine to just retain the DFS case only for now!

christopherbunn

Nit + question about warning but once addressed can approve!

evalml/pipelines/utils.py

…_pipeline_example

docs/source/release_notes.rst

…/evalml into js_4056_fix_dfs_pipeline_example

chukarsten

I think if we just change the check for DFS Transformer to be more robust based on the name attribute, we're good!

evalml/pipelines/utils.py

eccabay

Agreed with Karsten about removing reliance on the DFS transformer's name, and I'm worried about the implications of removing necessary repro information from __repr__

evalml/pipelines/utils.py

evalml/pipelines/pipeline_base.py

eccabay

Looks great!

evalml/pipelines/utils.py

evalml/tests/pipeline_tests/test_pipeline_utils.py

jeremyliweishih added 2 commits March 8, 2023 15:14

Fix example not working with DFS

429125e

RL

ce7e95c

Add seperate test case for generate_pipeline_code

6e668d3

jeremyliweishih marked this pull request as ready for review March 8, 2023 20:54

auto-assign bot assigned jeremyliweishih Mar 8, 2023

jeremyliweishih commented Mar 8, 2023

View reviewed changes

jeremyliweishih requested review from eccabay, chukarsten, christopherbunn and fjlanasa and removed request for eccabay March 8, 2023 21:00

christopherbunn requested changes Mar 9, 2023

View reviewed changes

evalml/pipelines/utils.py Show resolved Hide resolved

evalml/pipelines/utils.py Outdated Show resolved Hide resolved

jeremyliweishih added 3 commits March 9, 2023 14:13

Remove extra print

3d026b3

Merge branch 'main' of github.com:alteryx/evalml into js_4056_fix_dfs…

613cce2

…_pipeline_example

Add warnings

735f591

jeremyliweishih requested review from christopherbunn and tamargrey March 9, 2023 19:23

Merge branch 'main' into js_4056_fix_dfs_pipeline_example

bd1ac71

gsheni requested a review from thehomebrewnerd March 9, 2023 19:48

jeremyliweishih commented Mar 9, 2023

View reviewed changes

docs/source/release_notes.rst Outdated Show resolved Hide resolved

jeremyliweishih added 4 commits March 9, 2023 15:34

Fix release notes

9cb6a61

Merge branch 'js_4056_fix_dfs_pipeline_example' of github.com:alteryx…

2be4b04

…/evalml into js_4056_fix_dfs_pipeline_example

Merge branch 'main' into js_4056_fix_dfs_pipeline_example

6a255a2

Merge branch 'main' into js_4056_fix_dfs_pipeline_example

87026b0

christopherbunn approved these changes Mar 13, 2023

View reviewed changes

chukarsten suggested changes Mar 13, 2023

View reviewed changes

evalml/pipelines/utils.py Outdated Show resolved Hide resolved

eccabay requested changes Mar 13, 2023

View reviewed changes

evalml/pipelines/utils.py Show resolved Hide resolved

evalml/pipelines/utils.py Outdated Show resolved Hide resolved

evalml/pipelines/pipeline_base.py Show resolved Hide resolved

jeremyliweishih added 5 commits March 13, 2023 12:25

Address comments

4f34f89

Fix tests

254fbe6

Fix docs build

2c0b962

Merge branch 'main' into js_4056_fix_dfs_pipeline_example

ce3b819

Add validation for features path

a15870f

jeremyliweishih requested review from chukarsten and eccabay March 14, 2023 13:43

eccabay approved these changes Mar 14, 2023

View reviewed changes

evalml/pipelines/utils.py Show resolved Hide resolved

evalml/tests/pipeline_tests/test_pipeline_utils.py Show resolved Hide resolved

docstring

e85b976

chukarsten approved these changes Mar 14, 2023

View reviewed changes

jeremyliweishih added 2 commits March 14, 2023 17:16

Merge branch 'main' into js_4056_fix_dfs_pipeline_example

0901cd3

Fix test case with another primitive

f09ff18

jeremyliweishih enabled auto-merge (squash) March 14, 2023 23:00

jeremyliweishih merged commit 20d5b2c into main Mar 14, 2023

jeremyliweishih deleted the js_4056_fix_dfs_pipeline_example branch March 14, 2023 23:19

chukarsten mentioned this pull request Mar 15, 2023

Release v0.69.0 #4078

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix pipeline example erroring out on DFS #4059

Fix pipeline example erroring out on DFS #4059

jeremyliweishih commented Mar 8, 2023

codecov bot commented Mar 8, 2023 •

edited

Loading

jeremyliweishih Mar 8, 2023

tamargrey Mar 9, 2023

tamargrey Mar 9, 2023

jeremyliweishih Mar 9, 2023

jeremyliweishih Mar 8, 2023

jeremyliweishih Mar 8, 2023

christopherbunn Mar 9, 2023

christopherbunn left a comment

chukarsten left a comment

eccabay left a comment

eccabay left a comment

Fix pipeline example erroring out on DFS #4059

Fix pipeline example erroring out on DFS #4059

Conversation

jeremyliweishih commented Mar 8, 2023

codecov bot commented Mar 8, 2023 • edited Loading

Codecov Report

jeremyliweishih Mar 8, 2023

Choose a reason for hiding this comment

tamargrey Mar 9, 2023

Choose a reason for hiding this comment

tamargrey Mar 9, 2023

Choose a reason for hiding this comment

jeremyliweishih Mar 9, 2023

Choose a reason for hiding this comment

jeremyliweishih Mar 8, 2023

Choose a reason for hiding this comment

jeremyliweishih Mar 8, 2023

Choose a reason for hiding this comment

christopherbunn Mar 9, 2023

Choose a reason for hiding this comment

christopherbunn left a comment

Choose a reason for hiding this comment

chukarsten left a comment

Choose a reason for hiding this comment

eccabay left a comment

Choose a reason for hiding this comment

eccabay left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 8, 2023 •

edited

Loading