Skip to content

Remove oversampling nullable handling#4064

Merged
jeremyliweishih merged 7 commits intomainfrom
js_4013_remove_oversampling_handling
Mar 9, 2023
Merged

Remove oversampling nullable handling#4064
jeremyliweishih merged 7 commits intomainfrom
js_4013_remove_oversampling_handling

Conversation

@jeremyliweishih
Copy link
Copy Markdown
Collaborator

Fixes #4013.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 9, 2023

Codecov Report

Merging #4064 (280897b) into main (f7e5d40) will decrease coverage by 0.0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #4064     +/-   ##
=======================================
- Coverage   99.7%   99.7%   -0.0%     
=======================================
  Files        349     349             
  Lines      37523   37509     -14     
=======================================
- Hits       37405   37391     -14     
  Misses       118     118             
Impacted Files Coverage Δ
...es/components/transformers/samplers/oversampler.py 100.0% <ø> (ø)
evalml/tests/component_tests/test_oversampler.py 100.0% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamargrey
Copy link
Copy Markdown
Contributor

These tests are going to fail unless we raise the min sklearn version, I think https://github.com/alteryx/evalml/actions/runs/4376580073/jobs/7658890406#step:8:4233 since sklearn 1.2.1 is going to still have problems with nullable types

Comment thread evalml/tests/component_tests/test_oversampler.py Outdated
@jeremyliweishih jeremyliweishih marked this pull request as ready for review March 9, 2023 18:27
Comment thread .github/meta.yaml
@jeremyliweishih jeremyliweishih enabled auto-merge (squash) March 9, 2023 19:11
@jeremyliweishih jeremyliweishih merged commit 2b6a4e0 into main Mar 9, 2023
@jeremyliweishih jeremyliweishih deleted the js_4013_remove_oversampling_handling branch March 9, 2023 19:17
@chukarsten chukarsten mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Oversampler: Remove nullable type handling when imblearn adds nullable type support

3 participants