Skip to content

Pin ipywidgets version#4097

Merged
eccabay merged 2 commits into
mainfrom
pin-ipywidgets
Mar 21, 2023
Merged

Pin ipywidgets version#4097
eccabay merged 2 commits into
mainfrom
pin-ipywidgets

Conversation

@eccabay

@eccabay eccabay commented Mar 21, 2023

Copy link
Copy Markdown
Contributor

Closes #4098

The newest version of ipywidgets has a change that seems good for ipywidgets but bad for us. Failing tests are here.

@chukarsten chukarsten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending CI passing. Thank you!

@eccabay eccabay mentioned this pull request Mar 21, 2023
@eccabay
eccabay marked this pull request as ready for review March 21, 2023 19:01
@codecov

codecov Bot commented Mar 21, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4097 (feb698a) into main (75932ab) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4097   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        349     349           
  Lines      37548   37548           
=====================================
  Hits       37429   37429           
  Misses       119     119           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tamargrey tamargrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Can we make a follow-up ticket to fix the tests and unpin at some point when we have more bandwidth? Never mind, I see you already did -- thank you!

@eccabay
eccabay merged commit be8b543 into main Mar 21, 2023
@eccabay
eccabay deleted the pin-ipywidgets branch March 21, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pin ipywidgets under 8.0.5

3 participants