Fix ensembling for generate_pipeline_example#4102
Conversation
…_pipeline_example
…/evalml into js_4056_fix_dfs_pipeline_example
Codecov Report
@@ Coverage Diff @@
## main #4102 +/- ##
========================================
+ Coverage 84.6% 99.7% +15.2%
========================================
Files 349 349
Lines 37644 37661 +17
========================================
+ Hits 31812 37542 +5730
+ Misses 5832 119 -5713
... and 33 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
| aml.search() | ||
|
|
||
| pipeline = aml.get_pipeline(2) | ||
| if ensembling: |
There was a problem hiding this comment.
Ensembling pipelines do not work as each select columns transformer is not fit and will return no columns when using the test env. This also fails for any catboost or xgboost pipeline. Will file an issue to patch this behavior in AutoMLTestEnv but wanted to get this out first.
…valml into js_4101_fix_ensembling_example
jeremyliweishih
requested review from
christopherbunn,
chukarsten,
eccabay and
tamargrey
and removed request for
eccabay
| if not fit: | ||
| X_schema = ( | ||
| self._return_non_engineered_features(X).ww.schema | ||
| if "DFS Transformer" in self.compute_order |
There was a problem hiding this comment.
does this mean we were getting the input types wrong for stacked ensemble pipeline with the dfs transformer present?
There was a problem hiding this comment.
yes - this was not working for any ensemble with DFS transformer 😢
christopherbunn
left a comment
christopherbunn
left a comment
There was a problem hiding this comment.
Smaller nits but once the questions Tamar put up are addressed it LGTM
5 participants
Fixes #4101