Handle decomposer incompatibility

docs/source/release_notes.rst

@@ -8,6 +8,7 @@ Release Notes
         * Remove unnecessary logic from imputer components prior to nullable type handling :pr:`4038`
         * Added calls to ``_handle_nullable_types`` in component fit, transform, and predict methods when needed :pr:`4046`
         * Remove existing nullable type handling across AutoMLSearch to just use new handling :pr:`4085`
+        * Handle nullable type incompatibility in ``Decomposer`` :pr:`4105`
     * Documentation Changes
     * Testing Changes
         * Updated graphviz installation in GitHub workflows to fix windows nightlies :pr:`4088`

evalml/pipelines/components/transformers/preprocessing/decomposer.py

@@ -34,6 +34,9 @@ class Decomposer(Transformer):
     modifies_target = True
     needs_fitting = True
     invalid_frequencies = []
+    # Incompatibility: https://github.com/alteryx/evalml/issues/4103
+    # TODO: Remove when support is added https://github.com/pandas-dev/pandas/issues/52127
+    _integer_nullable_incompatibilities = ["y"]
 
     def __init__(
         self,
@@ -148,6 +151,7 @@ def determine_periodicity(
                 period is detected, returns None.
 
         """
+        X, y = cls._handle_nullable_types(cls, X, y)
 
         def _get_rel_max_from_acf(y):
             """Determines the relative maxima of the target's autocorrelation."""

evalml/tests/component_tests/decomposer_tests/test_decomposer.py

@@ -5,6 +5,7 @@
 import numpy as np
 import pandas as pd
 import pytest
+import woodwork as ww
 
 import evalml.exceptions
 from evalml.pipelines.components.transformers.preprocessing import (
@@ -438,6 +439,10 @@ def test_decomposer_set_period(decomposer_child_class, period, generate_seasonal
     assert dec.parameters["period"] == dec.period
 
 
+@pytest.mark.parametrize(
+    "y_logical_type",
+    ["Double", "Integer", "Age", "IntegerNullable", "AgeNullable"],
+)
 @pytest.mark.parametrize(
     "decomposer_child_class",
     decomposer_list,
@@ -451,6 +456,7 @@ def test_decomposer_set_period(decomposer_child_class, period, generate_seasonal
     ],
 )
 def test_decomposer_determine_periodicity(
+    y_logical_type,
     decomposer_child_class,
     period,
     trend_degree,
@@ -462,6 +468,7 @@ def test_decomposer_determine_periodicity(
         period,
         trend_degree=trend_degree,
     )
+    y = ww.init_series(y.astype(int), logical_type=y_logical_type)
 
     # Test that the seasonality can be determined if trend guess isn't spot on.
     if not decomposer_picked_correct_degree:
@@ -476,6 +483,61 @@ def test_decomposer_determine_periodicity(
         assert 0.95 * period <= ac <= 1.05 * period
 
 
+@pytest.mark.parametrize(
+    "decomposer_child_class",
+    decomposer_list,
+)
+@pytest.mark.parametrize(
+    "nullable_ltype",
+    ["IntegerNullable", "AgeNullable"],
+)
+@pytest.mark.parametrize(
+    "handle_incompatibility",
+    [
+        True,
+        pytest.param(
+            False,
+            marks=pytest.mark.xfail(strict=True, raises=AssertionError),
+        ),
+    ],
+)
+def test_decomposer_determine_periodicity_nullable_type_incompatibility(
+    decomposer_child_class,
+    handle_incompatibility,
+    nullable_ltype,
+    generate_seasonal_data,
+):
+    """Testing that the nullable type incompatibility that caused us to add handling for the Decomposer
+    is still present in pandas. If this test is causing the test suite to fail
+    because the code below no longer raises the expected AssertionError, we should confirm that the nullable
+    types now work for our use case and remove the nullable type handling logic from Decomposer.determine_periodicity.
+    """
+    trend_degree = 2
+    period = 7
+    X, y = generate_seasonal_data(real_or_synthetic="synthetic")(
+        period,
+        trend_degree=trend_degree,
+    )
+
+    # Convert to Integer, truncating the rest of the value
+    y = ww.init_series(y.astype(int), logical_type=nullable_ltype)
+
+    if handle_incompatibility:
+        dec = decomposer_child_class(degree=trend_degree, period=period)
+        X, y = dec._handle_nullable_types(X, y)
+
+    numpy_float_data = pd.Series(range(len(y)), dtype="float64")
+    numpy_float_data.iloc[-1] = np.nan
+
+    subtracted_floats = y - numpy_float_data
+
+    # Pandas will not recognize the np.NaN value in a Float64 subtracted_floats
+    # and will not drop that null value, so calling _handle_nullable_types ensures
+    # that we stay in float64 and properly drop the null value
+    dropped_nans = subtracted_floats.dropna()
+    assert len(dropped_nans) == len(y) - 1
+
+
 @pytest.mark.parametrize(
     "decomposer_child_class",
     decomposer_list,