Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dropping rows for InvalidTargetDataCheck #4116

Merged
merged 12 commits into from
Apr 5, 2023

Conversation

ParthivNaresh
Copy link
Contributor

Fixes: #4115

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #4116 (334b50c) into main (13d28c2) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4116     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      37719   37749     +30     
=======================================
+ Hits       37602   37632     +30     
  Misses       117     117             
Impacted Files Coverage Δ
evalml/data_checks/data_check_message.py 100.0% <ø> (ø)
evalml/data_checks/invalid_target_data_check.py 100.0% <100.0%> (ø)
...ata_checks_tests/test_invalid_target_data_check.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ParthivNaresh ParthivNaresh merged commit 535cbd5 into main Apr 5, 2023
@ParthivNaresh ParthivNaresh deleted the allow_dropping_rows_for_invalid_target_dc branch April 5, 2023 22:19
@chukarsten chukarsten mentioned this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow InvalidTargetDataCheck to return a DROP_ROWS action option
4 participants