Repository navigation
Remove nullable type handling for ARIMA and Exponential Smoothing - #4129
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4129 +/- ##
========================================
+ Coverage 59.8% 99.7% +40.0%
========================================
Files 349 349
Lines 37749 37704 -45
========================================
+ Hits 22550 37587 +15037
+ Misses 15199 117 -15082
... and 204 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
Author
|
Blocked on sktime conda - conda-forge/sktime-feedstock#70 |
|
looking into it, sorry for the delay |
eccabay
marked this pull request as ready for review
April 6, 2023 19:40
eccabay
requested review from
christopherbunn,
chukarsten,
jeremyliweishih and
tamargrey
April 6, 2023 19:40
|
🎉 😃 |
chukarsten
approved these changes
Apr 7, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4016
Sktime released support for nullable types in version 0.17.0