Skip to content

Remove nullable type handling for ARIMA and Exponential Smoothing - #4129

Merged
chukarsten merged 6 commits into
mainfrom
4016_sktime_nullable
Apr 7, 2023
Merged

chukarsten merged 6 commits into
mainfrom
4016_sktime_nullable

Conversation

@eccabay

@eccabay eccabay commented Apr 6, 2023

Copy link
Copy Markdown
Contributor

Closes #4016

Sktime released support for nullable types in version 0.17.0

@codecov

codecov Bot commented Apr 6, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #4129 (4ad08c1) into main (535cbd5) will increase coverage by 40.0%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##            main   #4129      +/-   ##
========================================
+ Coverage   59.8%   99.7%   +40.0%     
========================================
  Files        349     349              
  Lines      37749   37704      -45     
========================================
+ Hits       22550   37587   +15037     
+ Misses     15199     117   -15082     
Impacted Files Coverage Δ
...omponents/estimators/regressors/arima_regressor.py 100.0% <ø> (+20.2%) ⬆️
...tors/regressors/exponential_smoothing_regressor.py 100.0% <ø> (+21.6%) ⬆️
...alml/tests/component_tests/test_arima_regressor.py 100.0% <ø> (+100.0%) ⬆️
...nent_tests/test_exponential_smoothing_regressor.py 100.0% <ø> (+100.0%) ⬆️

... and 204 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eccabay

eccabay commented Apr 6, 2023

Copy link
Copy Markdown
Contributor Author

Blocked on sktime conda - conda-forge/sktime-feedstock#70

@fkiraly

fkiraly commented Apr 6, 2023

Copy link
Copy Markdown

looking into it, sorry for the delay

@eccabay
eccabay marked this pull request as ready for review April 6, 2023 19:40

@jeremyliweishih jeremyliweishih left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fkiraly

fkiraly commented Apr 7, 2023

Copy link
Copy Markdown

🎉 😃

@chukarsten
chukarsten merged commit 8d49f35 into main Apr 7, 2023
@chukarsten
chukarsten deleted the 4016_sktime_nullable branch April 7, 2023 16:59
@chukarsten chukarsten mentioned this pull request Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ARIMARegressor, ExponentialSmoothingRegressor: Remove nullable type handling once sktime supports nullable types in X

4 participants