Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin sktime to 0.17.0 #4137

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Pin sktime to 0.17.0 #4137

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9568a9c
Pin sktime to 0.17.0 only
eccabay Apr 11, 2023
a552d9f
Release notes
eccabay Apr 11, 2023
af6bdf1
Add missing release note
eccabay Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ outputs:
- lime >=0.2.0.1
- python >=3.8.*
- imbalanced-learn >=0.9.1
- sktime >=0.17.0
- sktime ==0.17.0
- pmdarima >=1.8.5
- vowpalwabbit >=8.11.0
test:
Expand Down
1 change: 1 addition & 0 deletions docs/source/release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ Release Notes
* Removed existing nullable type handling across AutoMLSearch to just use new handling :pr:`4085`, :pr:`4043`
* Handled nullable type incompatibility in ``Decomposer`` :pr:`4105`, :pr:`4043`
* Changed the default value for ``null_strategy`` in ``InvalidTargetDataCheck`` to ``drop`` :pr:`4131`
* Pinned sktime version to 0.17.0 for nullable types support :pr:`4137`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very random but I don't see your release note to remove nullable type handling from ARIMA and the ExponentialSmoothingRegressor. Seems it accidentally got removed in https://github.com/alteryx/evalml/pull/4131/files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, and good catch! Adding it back now

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this being pinned specifically for nullable types support? I thought it was more general? Or is it because we upgraded to 0.17.0 for nullable type support that we now have to == instead of <= 0.17.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter is correct, yeah. Pinned to == to maintain nullable type support.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it! I think this thread is good enough explanation, then, if anyone is looking at this in the future (hi!)

* Documentation Changes
* Testing Changes
* Fixed installation of prophet for linux nightly tests :pr:`4114`
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ dependencies = [
"category-encoders >= 2.2.2, <= 2.5.1.post0",
"imbalanced-learn >= 0.9.1",
"pmdarima >= 1.8.5",
"sktime >= 0.17.0",
"sktime == 0.17.0",
"lime >= 0.2.0.1",
"vowpalwabbit >= 8.11.0",
"tomli >= 2.0.1",
Expand Down