Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra naive pipelines #4142

Merged
merged 10 commits into from
Apr 18, 2023
Merged

Remove extra naive pipelines #4142

merged 10 commits into from
Apr 18, 2023

Conversation

christopherbunn
Copy link
Contributor

@christopherbunn christopherbunn commented Apr 12, 2023 •
edited

Resolves #4152

@christopherbunn christopherbunn force-pushed the TML-7245_rm_extra_naive_pipelines branch from 624ebb6 to 711f978 Compare April 17, 2023 15:53
@codecov
Copy link

codecov bot commented Apr 17, 2023 •
edited

Codecov Report

Merging #4142 (b380220) into main (134630a) will not change coverage.
The diff coverage is 100.0%.

@@          Coverage Diff          @@
##            main   #4142   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        349     349           
  Lines      37778   37778           
=====================================
  Hits       37661   37661           
  Misses       117     117
Impacted Files Coverage Δ
...valml/automl/automl_algorithm/default_algorithm.py 100.0% <ø> (ø)
evalml/tests/automl_tests/test_automl.py 99.6% <100.0%> (ø)
...valml/tests/automl_tests/test_default_algorithm.py 100.0% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@christopherbunn christopherbunn marked this pull request as ready for review April 17, 2023 19:00
jeremyliweishih
jeremyliweishih approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/source/user_guide/timeseries.ipynb Outdated
@@ -540,6 +540,7 @@
" y_train,\n",
" problem_type=\"time series regression\",\n",
" max_batches=1,\n",
" automl_algorithm=\"iterative\",\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you add this for allowed_model_families to work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, previously it only just ran the first batch which didn't get great results

@christopherbunn christopherbunn merged commit 21eb2ff into main Apr 18, 2023
28 checks passed
@christopherbunn christopherbunn deleted the TML-7245_rm_extra_naive_pipelines branch April 18, 2023 15:10
@chukarsten chukarsten mentioned this pull request Apr 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@eccabay eccabay eccabay approved these changes

@fjlanasa fjlanasa Awaiting requested review from fjlanasa

@chukarsten chukarsten Awaiting requested review from chukarsten

Assignees

@christopherbunn christopherbunn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Extra Naive Pipelines from AutoML Search Process
3 participants
@christopherbunn @jeremyliweishih @eccabay