Fix resetting y_holdout index for time series#4161
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4161 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 349 349
Lines 37777 37797 +20
=======================================
+ Hits 37660 37680 +20
Misses 117 117
|
jeremyliweishih
approved these changes
Apr 27, 2023
Collaborator
jeremyliweishih
left a comment
There was a problem hiding this comment.
LGTM - thank you!
chukarsten
approved these changes
May 1, 2023
Contributor
chukarsten
left a comment
There was a problem hiding this comment.
Thanks for tracking this down! Aside from the internal terminology/variable naming, this looks g2g.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4159