Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resetting y_holdout index for time series #4161

Merged
merged 5 commits into from
May 1, 2023
Merged

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Apr 27, 2023

Closes #4159

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #4161 (865d6df) into main (2eee8cb) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4161     +/-   ##
=======================================
+ Coverage   99.7%   99.7%   +0.1%     
=======================================
  Files        349     349             
  Lines      37777   37797     +20     
=======================================
+ Hits       37660   37680     +20     
  Misses       117     117             
Impacted Files Coverage Δ
evalml/pipelines/time_series_pipeline_base.py 100.0% <100.0%> (ø)
.../tests/pipeline_tests/test_time_series_pipeline.py 100.0% <100.0%> (ø)

@eccabay eccabay changed the title Add fix for when y_index is reset Fix resetting y_holdout index for time series Apr 27, 2023
@eccabay eccabay marked this pull request as ready for review April 27, 2023 14:11
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you!

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down! Aside from the internal terminology/variable naming, this looks g2g.

evalml/pipelines/time_series_pipeline_base.py Outdated Show resolved Hide resolved
@eccabay eccabay enabled auto-merge (squash) May 1, 2023 17:59
@eccabay eccabay merged commit 4aaf037 into main May 1, 2023
@eccabay eccabay deleted the 4159_ts_reset_holdout branch May 1, 2023 18:25
@chukarsten chukarsten mentioned this pull request May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time Series estimators fail when y_holdout.index is reset
3 participants