Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small ARIMA issues #4186

Merged
merged 5 commits into from May 24, 2023
Merged

Fix small ARIMA issues #4186

merged 5 commits into from May 24, 2023

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented May 23, 2023

Closes #4185

@codecov
Copy link

codecov bot commented May 23, 2023 •
edited

Codecov Report

Merging #4186 (2cd0da5) into main (21e193b) will increase coverage by 6.4%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #4186     +/-   ##
=======================================
+ Coverage   93.4%   99.7%   +6.4%     
=======================================
  Files        349     349             
  Lines      38094   38107     +13     
=======================================
+ Hits       35574   37990   +2416     
+ Misses      2520     117   -2403
Impacted Files Coverage Δ
...omponents/estimators/regressors/arima_regressor.py 100.0% <100.0%> (ø)
...alml/tests/component_tests/test_arima_regressor.py 100.0% <100.0%> (ø)
evalml/tests/conftest.py 98.3% <100.0%> (+4.1%) ⬆️

... and 15 files with indirect coverage changes

@eccabay eccabay marked this pull request as ready for review May 23, 2023 18:46
jeremyliweishih
jeremyliweishih approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christopherbunn
christopherbunn approved these changes May 24, 2023
View reviewed changes
Copy link
Contributor

@christopherbunn christopherbunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eccabay eccabay merged commit d497349 into main May 24, 2023
24 checks passed
@eccabay eccabay deleted the 4185_arima_issues branch May 24, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherbunn christopherbunn christopherbunn approved these changes

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@chukarsten chukarsten Awaiting requested review from chukarsten

Assignees

@eccabay eccabay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Harden ARIMA implementation
3 participants
@eccabay @christopherbunn @jeremyliweishih