Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpinned sktime version #4214

Merged
merged 7 commits into from Jul 11, 2023
Merged

Unpinned sktime version #4214

merged 7 commits into from Jul 11, 2023

Conversation

remyogasawara
Copy link
Collaborator

@remyogasawara remyogasawara commented Jun 27, 2023 •
edited

Resolves: #4138

@CLAassistant
Copy link

CLAassistant commented Jun 27, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited

Codecov Report

Merging #4214 (5801390) into main (6e82a80) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4214   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        349     349           
  Lines      38294   38294           
=====================================
  Hits       38174   38174           
  Misses       120     120
Impacted Files Coverage Δ
...alml/tests/component_tests/test_arima_regressor.py 100.0% <ø> (ø)

@remyogasawara remyogasawara changed the title unpin sktime Unpin sktime Jun 27, 2023
@remyogasawara remyogasawara marked this pull request as draft June 27, 2023 05:58
remyogasawara
remyogasawara commented Jun 28, 2023
View reviewed changes
evalml/tests/component_tests/test_arima_regressor.py
@@ -203,7 +203,6 @@ def test_feature_importance(ts_data):
[
(True, False, False, False, False, False),
(False, True, True, False, False, True),
(False, True, True, False, False, False),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We deleted this test case because sktime depreciated integer indexes

@remyogasawara remyogasawara marked this pull request as ready for review June 28, 2023 19:20
@christopherbunn
Copy link
Contributor

christopherbunn commented Jun 28, 2023 •
edited

Might need to be addressed in either this PR or another one but I think we also need to cap the pandas version for conda for now. Here's a passing build with 1.5.3 while this build fails with 2.0.2.

We can cap pandas in the EvalML repo or in the Conda recipe on this line.

@jeremyliweishih
Copy link
Contributor

Might need to be addressed in either this PR or another one but I think we also need to cap the pandas version for conda for now. Here's a passing build with 1.5.3 while this build fails with 2.0.2.

We can cap pandas in the EvalML repo or in the Conda recipe on this line.

Its only passing in the other tests because pandas-1.5.3 is being installed. I think theres a difference in dependency resolution between pip and conda. I think we should just bump pandas to be > 2.0.0 and change the append calls we have to to use concat instead! What do you think @christopherbunn @remyogasawara

@christopherbunn
Copy link
Contributor

@jeremyliweishih I agree that we should bump it up, but I think we should it in a follow up issue. It would keep the pandas 2.0 work separate from this PR. Should we open another PR for the pandas fixes only, merge that in, then rebase and get this in?

@christopherbunn christopherbunn changed the title Unpin sktime Unpinned sktime version Jul 11, 2023
@christopherbunn christopherbunn enabled auto-merge (squash) July 11, 2023 18:19
jeremyliweishih
jeremyliweishih approved these changes Jul 11, 2023
View reviewed changes
.github/meta.yaml
@@ -25,7 +25,7 @@ outputs:
- setuptools ==58.0.4
run:
- numpy >=1.21.0
- pandas >=1.5.0
- pandas >=1.5.0, <2.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file an issue to unpin if we don't already have one?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do mention that we were not supporting it before as pip would not install > 2.0

@christopherbunn christopherbunn merged commit 2481ed1 into main Jul 11, 2023
26 checks passed
@christopherbunn christopherbunn deleted the 4138_unpin_sktime branch July 11, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyliweishih jeremyliweishih jeremyliweishih approved these changes

@christopherbunn christopherbunn christopherbunn approved these changes

@fjlanasa fjlanasa Awaiting requested review from fjlanasa

@eccabay eccabay Awaiting requested review from eccabay

@chukarsten chukarsten Awaiting requested review from chukarsten

Assignees

@remyogasawara remyogasawara

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpin sktime
4 participants
@remyogasawara @CLAassistant @christopherbunn @jeremyliweishih