Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LightGBM not verbose #4308

Merged
merged 5 commits into from Sep 19, 2023
Merged

Make LightGBM not verbose #4308

merged 5 commits into from Sep 19, 2023

Conversation

MichaelFu512
Copy link
Contributor

@MichaelFu512 MichaelFu512 commented Sep 14, 2023

Pull Request Description

Closes #4307

Whenever you run automl.search(), LightGBM really likes to say the same warning over and over again.

For example, in the start page of the documentation for EvalML even if you set verbose=False:
Screen Shot 2023-09-14 at 11 56 37 AM

the output has this:

Screen Shot 2023-09-14 at 11 44 09 AM This continues for like 70 more lines.

After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (46baada) 99.7% compared to head (09b1d19) 99.7%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4308   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        357     357           
  Lines      39739   39739           
=====================================
  Hits       39619   39619           
  Misses       120     120           
Files Changed Coverage Δ
...ents/estimators/classifiers/lightgbm_classifier.py 100.0% <ø> (ø)
evalml/tests/component_tests/test_components.py 99.1% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -108,6 +108,7 @@ def __init__(
"n_jobs": n_jobs,
"bagging_freq": bagging_freq,
"bagging_fraction": bagging_fraction,
"verbose": -1,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this does suppress everything that LightGBM would display. (including info and warnings).

@MichaelFu512 MichaelFu512 marked this pull request as ready for review September 15, 2023 16:29
Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@MichaelFu512 MichaelFu512 merged commit 90b0e5c into main Sep 19, 2023
24 checks passed
@MichaelFu512 MichaelFu512 deleted the doc-fix branch September 19, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make LightGBM not repeat the same warning
3 participants