Update split_data to call split_multiseries_data#4312
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4312 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 357 357
Lines 39739 39767 +28
=======================================
+ Hits 39619 39647 +28
Misses 120 120
☔ View full report in Codecov by Sentry. |
eccabay
requested review from
MichaelFu512,
christopherbunn and
jeremyliweishih
jeremyliweishih
requested changes
Sep 18, 2023
Collaborator
jeremyliweishih
left a comment
jeremyliweishih
left a comment
There was a problem hiding this comment.
Some quick comments but otherwise LGTM
| problem_configuration = None | ||
| if is_time_series(problem_type): | ||
| if is_multiseries(problem_type): | ||
| pytest.skip("Multiseries time series is tested separately") |
Collaborator
There was a problem hiding this comment.
Instead of skipping could we mock out the multi series split and asset that it's called?
MichaelFu512
approved these changes
Sep 18, 2023
jeremyliweishih
approved these changes
Sep 19, 2023
christopherbunn
approved these changes
Sep 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4311