Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes XGBoost classifier bug with feature names that contain [, ], or < #659

Merged
merged 30 commits into from Apr 17, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Apr 15, 2020

Closes #589

@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #659 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #659      +/-   ##
==========================================
+ Coverage   99.06%   99.07%   +0.01%     
==========================================
  Files         139      139              
  Lines        4907     4963      +56     
==========================================
+ Hits         4861     4917      +56     
  Misses         46       46              
Impacted Files Coverage Δ
...nents/estimators/classifiers/xgboost_classifier.py 100.00% <100.00%> (ø)
...ponents/estimators/regressors/xgboost_regressor.py 100.00% <100.00%> (ø)
evalml/tests/component_tests/test_components.py 100.00% <100.00%> (ø)
...l/tests/component_tests/test_xgboost_classifier.py 100.00% <100.00%> (ø)
...ml/tests/component_tests/test_xgboost_regressor.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fd092d...a487291. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review Apr 16, 2020
@angela97lin angela97lin requested a review from dsherry Apr 16, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Solid start, left some suggestions!

@dsherry
Copy link
Collaborator

dsherry commented Apr 16, 2020

@angela97lin : heads up @jeremyliweishih is about to add an xgboost regression component and pipeline in #666. If he merges before you do, you'll need to give the regressor the same treatment as the classifier, right? Someone will have to do it either way, haha.

@angela97lin angela97lin requested review from dsherry and kmax12 Apr 17, 2020
kmax12
kmax12 approved these changes Apr 17, 2020
Copy link
Collaborator

@dsherry dsherry left a comment

Left a few more requests, but after that this is ready to go from my perspective!

@dsherry
Copy link
Collaborator

dsherry commented Apr 17, 2020

@angela97lin I know you're about to merge this (!!!) but reminder to move PRs which are in review to Review/QA

@angela97lin
Copy link
Contributor Author

angela97lin commented Apr 17, 2020

@dsherry gotcha, moved!

@angela97lin angela97lin requested a review from dsherry Apr 17, 2020
@dsherry
Copy link
Collaborator

dsherry commented Apr 17, 2020

@angela97lin I left a couple more suggestions, very close :)

Copy link
Collaborator

@dsherry dsherry left a comment

I think I already approved this but re-approving haha, great stuff!

@angela97lin angela97lin merged commit 3099cb9 into master Apr 17, 2020
2 checks passed
@dsherry dsherry deleted the 589_xgb_names branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XGBoostClassifier does not work with feature names that contain [, ], or <
3 participants