-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes XGBoost classifier bug with feature names that contain [, ], or < #659
Conversation
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
==========================================
+ Coverage 99.06% 99.07% +0.01%
==========================================
Files 139 139
Lines 4907 4963 +56
==========================================
+ Hits 4861 4917 +56
Misses 46 46
Continue to review full report at Codecov.
|
evalml/pipelines/components/estimators/classifiers/xgboost_classifier.py
Outdated
Show resolved
Hide resolved
evalml/tests/pipeline_tests/classification_pipeline_tests/test_xgboost.py
Outdated
Show resolved
Hide resolved
evalml/pipelines/components/estimators/classifiers/xgboost_classifier.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid start, left some suggestions!
@angela97lin : heads up @jeremyliweishih is about to add an xgboost regression component and pipeline in #666. If he merges before you do, you'll need to give the regressor the same treatment as the classifier, right? Someone will have to do it either way, haha. |
evalml/pipelines/components/estimators/classifiers/xgboost_classifier.py
Outdated
Show resolved
Hide resolved
evalml/pipelines/components/estimators/classifiers/xgboost_classifier.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few more requests, but after that this is ready to go from my perspective!
@angela97lin I know you're about to merge this (!!!) but reminder to move PRs which are in review to Review/QA |
@dsherry gotcha, moved! |
evalml/pipelines/components/estimators/classifiers/xgboost_classifier.py
Show resolved
Hide resolved
evalml/pipelines/components/estimators/classifiers/xgboost_classifier.py
Show resolved
Hide resolved
@angela97lin I left a couple more suggestions, very close :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I already approved this but re-approving haha, great stuff!
Closes #589