Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove s3fs dependency to avoid boto pip install error #664

Merged
merged 3 commits into from Apr 16, 2020

Conversation

dsherry
Copy link
Collaborator

@dsherry dsherry commented Apr 16, 2020

Fix #592

I made the leads demo files publicly accessible in S3. Now we can get them via urllib instead of pandas s3fs support, and remove the s3fs dev dependency, which was installing boto, which was causing a version mismatch error regarding docutils. Whew.

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #664 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #664   +/-   ##
=======================================
  Coverage   99.02%   99.02%           
=======================================
  Files         135      135           
  Lines        4709     4709           
=======================================
  Hits         4663     4663           
  Misses         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f306797...bdd6e33. Read the comment docs.

@dsherry dsherry marked this pull request as ready for review April 16, 2020 18:20
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - maybe when we open source we can move these files locally.

@dsherry dsherry merged commit d154ade into master Apr 16, 2020
@dsherry dsherry deleted the ds_592_replace_s3fs branch April 16, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dependency install error message
2 participants