Remove s3fs dependency to avoid boto pip install error #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #664 +/- ##
=======================================
Coverage 99.02% 99.02%
=======================================
Files 135 135
Lines 4709 4709
=======================================
Hits 4663 4663
Misses 46 46 Continue to review full report at Codecov.
|
dsherry
force-pushed
the
ds_592_replace_s3fs
branch
from
8991a9c
to
5cff4d1
Compare
jeremyliweishih
approved these changes
Apr 16, 2020
dsherry
force-pushed
the
ds_592_replace_s3fs
branch
from
5cff4d1
to
bdd6e33
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #592
I made the leads demo files publicly accessible in S3. Now we can get them via
urllibinstead of pandass3fssupport, and remove thes3fsdev dependency, which was installingboto, which was causing a version mismatch error regardingdocutils. Whew.