Added support for unlim pipelines with max_time limit #70
Conversation
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 95.52% 95.75% +0.22%
==========================================
Files 57 58 +1
Lines 1498 1531 +33
==========================================
+ Hits 1431 1466 +35
+ Misses 67 65 -2
Continue to review full report at Codecov.
|
evalml/models/auto_base.py
Outdated
| start = time.time() | ||
| elapsed = 0 | ||
| last_time = start | ||
| with tqdm(total=self.max_time, disable=not self.verbose, file=stdout) as pbar: |
There was a problem hiding this comment.
Currently, the progress bar may be misleading since if training starts at 99% it could hang depending on how long training would take to finish. Maybe we can remove the progress bar and only show elapsed time using bar_format in tqdm or somehow let the bar reflect time elapsed and not dependent on training iterations.
|
@christopherbunn can we document this new functionality? i think the best place would be in this section https://evalml.featurelabs.com/en/latest/automl/pipeline_search.html#Limiting-Search-Time |
evalml/models/auto_base.py
Outdated
| start = time.time() | ||
| elapsed = 0 | ||
| pbar = tqdm(total=self.max_time, disable=not self.verbose, file=stdout, bar_format='{desc} | Elapsed:{elapsed}') | ||
| while elapsed <= self.max_time: |
There was a problem hiding this comment.
can we just make this while time.time() - start <= self.max_time: and remove the elapsed variable?
|
@christopherbunn if it's not too much of a hassle, could you move the changelog line to "Future Releases" instead of under v.0.5.0? |
|
@angela97lin Sure |
* Added support for unlim pipelines with max_time limit * Fixed lint errors * Increased number of test_binary_auto pipelines to 5 * Fixed max_pipelines=None behavior and removed extraneous comment * Revered some Autoclassifier tests to use max_pipelines=5 * Changed the format of the progress logs for max_time * Changed to new pbar format and modified error msg * Updated notebook example to include search limit * Updated limit handling to allow for no time parameters * Fixed lint errors * Updated changelog * Closed pbear on early termination and removed new_line * Status bar changes * Fixed lint error * Updated test and removed elasped variable * Fixed position in changelog * Removed duplicate line
Added support for the construction of unlimited pipelines, as long as a time limit is specified. If no limits are specified, an error is thrown. (#14)