Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes summary for Pipelines without estimators #707

Merged
merged 15 commits into from Apr 24, 2020
Merged

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Apr 24, 2020

Closes #706

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #707 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #707      +/-   ##
==========================================
+ Coverage   99.19%   99.21%   +0.02%     
==========================================
  Files         140      140              
  Lines        4952     4985      +33     
==========================================
+ Hits         4912     4946      +34     
+ Misses         40       39       -1     
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 99.51% <100.00%> (+0.47%) ⬆️
...ion_pipeline_tests/test_catboost_classification.py 100.00% <100.00%> (ø)
...ication_pipeline_tests/test_logistic_regression.py 100.00% <100.00%> (ø)
...ine_tests/classification_pipeline_tests/test_rf.py 100.00% <100.00%> (ø)
...tion_pipeline_tests/test_xgboost_classification.py 100.00% <100.00%> (ø)
...ression_pipeline_tests/test_catboost_regression.py 100.00% <100.00%> (ø)
...egression_pipeline_tests/test_linear_regression.py 100.00% <100.00%> (ø)
...ts/regression_pipeline_tests/test_rf_regression.py 100.00% <100.00%> (ø)
...gression_pipeline_tests/test_xgboost_regression.py 100.00% <100.00%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.63% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360fc60...ad61ca7. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review Apr 24, 2020
@angela97lin angela97lin requested a review from dsherry Apr 24, 2020
evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dsherry dsherry left a comment

Looking good, left suggestions

@angela97lin angela97lin requested a review from dsherry Apr 24, 2020
evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
evalml/pipelines/pipeline_base.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@dsherry dsherry left a comment

Nice going! Left a couple style suggestions on the impl but lgtm 🚢

@angela97lin angela97lin merged commit fca8e60 into master Apr 24, 2020
2 checks passed
@dsherry dsherry deleted the 706_summary branch Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

summary for Pipelines without an estimator component is incorrect
2 participants