Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic one-hot encoding #73

Merged
merged 19 commits into from Sep 18, 2019
Merged

Added basic one-hot encoding #73

merged 19 commits into from Sep 18, 2019

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Sep 13, 2019

No description provided.

@jeremyliweishih jeremyliweishih requested review from kmax12 and removed request for kmax12 Sep 13, 2019
@jeremyliweishih jeremyliweishih changed the title Added basic one-hot encoding WIP: Added basic one-hot encoding Sep 13, 2019
@jeremyliweishih jeremyliweishih changed the title WIP: Added basic one-hot encoding Added basic one-hot encoding Sep 13, 2019
@jeremyliweishih jeremyliweishih requested a review from kmax12 Sep 13, 2019
@jeremyliweishih jeremyliweishih added this to the Sprint #1 milestone Sep 13, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

overall looks good. one thing we should add in is a test for looking at variable importance after doing the categorical encoding.

we might also look for somewhere in the documentation to add a comment about handling categoricals now

evalml/pipelines/classification/logistic_regression.py Outdated Show resolved Hide resolved
evalml/pipelines/classification/logistic_regression.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@kmax12 kmax12 left a comment

just one comment. otherwise, just need to add documentation and update fraud demo

requirements.txt Outdated Show resolved Hide resolved
kmax12
kmax12 previously approved these changes Sep 18, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

This looks good, but we still need to the documentation updates. Could be in this PR or another, whichever you prefer

Copy link
Contributor

@kmax12 kmax12 left a comment

just one comment, otherwise good to merge

docs/source/roadmap.rst Outdated Show resolved Hide resolved
kmax12
kmax12 approved these changes Sep 18, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

LGTM

@jeremyliweishih jeremyliweishih merged commit a3d3304 into master Sep 18, 2019
@jeremyliweishih jeremyliweishih deleted the one-hot branch Sep 18, 2019
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants