Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit nonzero code if codecov fails to upload #810

Merged
merged 2 commits into from May 26, 2020
Merged

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented May 26, 2020

@ctduffy just hit a timeout on her PR, so I figure we should clean this one up.

From the codecov binary help output:

  --required            If Codecov fails it will exit 1 - possibly failing the
                        CI build.

@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #810 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #810   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         150      150           
  Lines        5781     5781           
=======================================
  Hits         5753     5753           
  Misses         28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 922c404...41fa57e. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM!

@dsherry dsherry merged commit c79de1a into master May 26, 2020
@dsherry dsherry deleted the ds_749_fail_codecov branch May 26, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants