Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codecov #90

Merged
merged 5 commits into from Sep 19, 2019
Merged

Added codecov #90

merged 5 commits into from Sep 19, 2019

Conversation

jeremyliweishih
Copy link
Contributor

@jeremyliweishih jeremyliweishih commented Sep 18, 2019

No description provided.

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

No coverage uploaded for pull request base (master@a3d3304). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #90   +/-   ##
=========================================
  Coverage          ?   92.41%           
=========================================
  Files             ?       47           
  Lines             ?     1226           
  Branches          ?        0           
=========================================
  Hits              ?     1133           
  Misses            ?       93           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3d3304...2f92ec1. Read the comment docs.

@jeremyliweishih
Copy link
Contributor Author

jeremyliweishih commented Sep 18, 2019

Check #91 to see an example of where code-cov compares (even though there is 0 coverage change).

@jeremyliweishih jeremyliweishih requested a review from kmax12 Sep 18, 2019
@jeremyliweishih jeremyliweishih changed the title WIP: Added codecov Added codecov Sep 18, 2019
Copy link
Contributor

@kmax12 kmax12 left a comment

can we add the codecov badge to the repo readme?

also, does this require codecov to pass in order to merge a PR like we do in Featuretools?

@jeremyliweishih
Copy link
Contributor Author

jeremyliweishih commented Sep 18, 2019

kmax12
kmax12 approved these changes Sep 18, 2019
@jeremyliweishih jeremyliweishih merged commit d7bd82b into master Sep 19, 2019
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
@dsherry dsherry deleted the code-cov branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants