-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reordered columns in describe_pipeline
to make main objective first column
#94
Conversation
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 92.41% 92.54% +0.13%
==========================================
Files 47 47
Lines 1226 1248 +22
==========================================
+ Hits 1133 1155 +22
Misses 93 93
Continue to review full report at Codecov.
|
Could you add a test case? |
Sure! Where's a good place to test this? (I wasn't able to find any previous tests for describe_pipeline?) |
test_additional_objectives in test_autoclassifier.py is fairly similar |
Hmmm, since we only change the order of what's logged/printed and not what is actually stored in the dictionary (pipeline_results["all_objective_scores"]), it's difficult to check the returned dictionary... |
pytest has fixtures (capsys and caplog) you can use to examine the output of a test case |
…lml into first_col_main_objective
fixes #86 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
No description provided.