Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reordered columns in describe_pipeline to make main objective first column #94

Merged
merged 15 commits into from Sep 25, 2019

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Sep 18, 2019

No description provided.

@angela97lin angela97lin requested a review from rwedge Sep 18, 2019
@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #94 into master will increase coverage by 0.13%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
+ Coverage   92.41%   92.54%   +0.13%     
==========================================
  Files          47       47              
  Lines        1226     1248      +22     
==========================================
+ Hits         1133     1155      +22     
  Misses         93       93
Impacted Files Coverage Δ
evalml/pipelines/pipeline_base.py 96.66% <100%> (+0.05%) ⬆️
evalml/objectives/utils.py 100% <100%> (ø) ⬆️
evalml/tests/test_autoclassifier.py 100% <100%> (ø) ⬆️
evalml/models/auto_base.py 91.5% <90.9%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bd82b...9cb6ae5. Read the comment docs.

@rwedge
Copy link
Contributor

rwedge commented Sep 19, 2019

Could you add a test case?

@angela97lin
Copy link
Contributor Author

angela97lin commented Sep 19, 2019

Sure! Where's a good place to test this? (I wasn't able to find any previous tests for describe_pipeline?)

@rwedge
Copy link
Contributor

rwedge commented Sep 19, 2019

test_additional_objectives in test_autoclassifier.py is fairly similar

@angela97lin
Copy link
Contributor Author

angela97lin commented Sep 19, 2019

Hmmm, since we only change the order of what's logged/printed and not what is actually stored in the dictionary (pipeline_results["all_objective_scores"]), it's difficult to check the returned dictionary...

@rwedge
Copy link
Contributor

rwedge commented Sep 20, 2019

pytest has fixtures (capsys and caplog) you can use to examine the output of a test case

@kmax12
Copy link
Contributor

kmax12 commented Sep 23, 2019

fixes #86

@angela97lin
Copy link
Contributor Author

angela97lin commented Sep 24, 2019

Also fixes #101 and #102

evalml/tests/test_autoclassifier.py Outdated Show resolved Hide resolved
rwedge
rwedge approved these changes Sep 25, 2019
Copy link
Contributor

@rwedge rwedge left a comment

Looks good

@angela97lin angela97lin merged commit 93c8adb into master Sep 25, 2019
@angela97lin angela97lin deleted the first_col_main_objective branch Sep 25, 2019
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants