-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically infer multiclass based off of objective #99
Conversation
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 93.49% 93.72% +0.23%
==========================================
Files 52 52
Lines 1306 1355 +49
==========================================
+ Hits 1221 1270 +49
Misses 85 85
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic seems good. just some comments on making code a bit cleaner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This changes the default behavior of multiclass.
If there is a given objective it will do the following:
The default objective will be binary precision and if multiclass is set to TRUE it will default to precision_micro.
Also adds a check so users who end up with a mismatch of objective and multiclass will have an easier error to handle.