Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_deep_feature_synthesis to remove ft.dfs calls #1306

Merged
merged 3 commits into from Jan 13, 2021

Conversation

thehomebrewnerd
Copy link
Contributor

Update test_deep_feature_synthesis to remove ft.dfs calls

Update several tests in test_deep_feature_synthesis.py to use DeepFeatureSynthesis object to generate features instead of calling ft.dfs with features_only=True.

Closes #1305

@thehomebrewnerd thehomebrewnerd self-assigned this Jan 13, 2021
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #1306 (eb1b578) into main (3c00001) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1306   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         135      135           
  Lines       14489    14496    +7     
=======================================
+ Hits        14255    14262    +7     
  Misses        234      234           
Impacted Files Coverage Δ
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.15% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c00001...eb1b578. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@thehomebrewnerd thehomebrewnerd merged commit 594641b into main Jan 13, 2021
@thehomebrewnerd thehomebrewnerd deleted the fix-test-dfs branch January 13, 2021 21:04
@rwedge rwedge mentioned this pull request Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests in test_deep_feature_synthesis.py
2 participants