Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release branch naming instructions #1345

Merged
merged 4 commits into from
Feb 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Expand Up @@ -105,7 +105,7 @@ jobs:
run: |
from re import compile
main = '^main$'
release = '^v\d+\.\d+\.\d+$'
release = '^release_v\d+\.\d+\.\d+$'
dep_update = '^dep-update-[a-f0-9]{7}$'
regex = main, release, dep_update
patterns = list(map(compile, regex))
Expand Down
1 change: 1 addition & 0 deletions docs/source/release_notes.rst
Expand Up @@ -14,6 +14,7 @@ Release Notes
* Warn python 3.6 users suppport will be dropped in future release (:pr:`1344`)
* Documentation Changes
* Update docs for defining custom primitives (:pr:`1332`)
* Update featuretools release instructions (:pr:`1345`)
* Testing Changes

Thanks to the following people for contributing to this release:
Expand Down
8 changes: 4 additions & 4 deletions release.md
Expand Up @@ -6,13 +6,13 @@ Conda releases of featuretools rely on PyPI's hosted featuretools packages. Once
We need to upload a featuretools package to test with the conda recipe
1. Make a new development release branch on featuretools (in this example we'll be testing the 0.13.3 release)
```bash
git checkout -b v0.13.3.dev
git checkout -b dev_v0.13.3
```
2. Update version number in `setup.py`, `featuretools/version.py`, `featuretools/tests/test_version.py` to v0.13.3.dev0 and push branch to repo
3. Publish a new release of featuretools on Github.
1. Go to the [releases page](https://github.com/alteryx/featuretools/releases/) on Github
2. Click "Draft a new release"
3. For the target, choose the new branch (v0.13.3.dev)
3. For the target, choose the new branch (dev_v0.13.3)
4. For the tag, use the new version number (v0.13.3.dev0)
5. For the release title, use the new version number (v0.13.3.dev0)
6. For the release description, write "Development release for testing purposes"
Expand All @@ -35,7 +35,7 @@ Branches on the conda-forge featuretools repo are automatically built and the pa
git merge upstream/master
git push origin master
```
5. Make a branch with the version you want to release
5. Make a branch with the version number you want to release
```bash
git checkout -b v0.13.0.dev0
```
Expand Down Expand Up @@ -97,7 +97,7 @@ Fields to update in `recipe/meta.yaml` of feedstock repo:

## Create featuretools release on github
#### Create release branch
1. Branch off of featuretools main and name the branch the release version number (e.g. v0.13.3)
1. Branch off of featuretools main. For the branch name, please use "release_vX.Y.Z" as the naming scheme (e.g. "release_v0.13.3"). Doing so will bypass our release notes checkin test which requires all other PRs to add a release note entry.

#### Bump version number
2. Bump version number in `setup.py`, `featuretools/version.py`, and `featuretools/tests/test_version.py`.
Expand Down