Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add primitive init tests #1726

Merged
merged 2 commits into from Sep 28, 2021
Merged

Add primitive init tests #1726

merged 2 commits into from Sep 28, 2021

Conversation

thehomebrewnerd
Copy link
Contributor

Add primitive init tests

Closes #1717

Adds explicit tests to verify all primitives can be initialized without specifying any parameter values.

rwedge
rwedge approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gsheni gsheni requested review from davesque and removed request for davesque September 28, 2021 20:52
@thehomebrewnerd thehomebrewnerd merged commit 2e2f925 into main Sep 28, 2021
@thehomebrewnerd thehomebrewnerd deleted the add-prim-init-test branch September 28, 2021 20:59
@thehomebrewnerd thehomebrewnerd mentioned this pull request Oct 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwedge rwedge rwedge approved these changes

Assignees

@thehomebrewnerd thehomebrewnerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test to verify all primitives can be initialized without passing parameter values
2 participants
@thehomebrewnerd @rwedge