Add sqrt, log, sin, cos and tan transform primitives

[tvdboom]

• Fixes Add Sine, Cosine, Tangent, SquareRoot, Log primitives #1943

[CLAassistant]

All committers have signed the CLA.

[tvdboom]

I couldn't find a test where all primitives are systematically tested. Do I need to add a separate test for each or how should it be done?

[thehomebrewnerd]

I couldn't find a test where all primitives are systematically tested. Do I need to add a separate test for each or how should it be done?

@tvdboom First, thanks for the contribution!

Second, the transform primitives should all get tested in test_transform_features.py in the test_init_and_name test:

featuretools/featuretools/tests/primitive_tests/test_transform_features.py

Line 71 in 3937593

def test_init_and_name(es):

That test should make sure that a feature is created using the primitive and that it calculates without error. That test does not actually test that the calculation is being performed correctly, but since you are using standard numpy functions, I don't think we need to worry about testing the results for correctness in this case, outside of the docstring tests.

[tvdboom]

@thehomebrewnerd So if I understood correctly, since test_init_and_name fetches all transform primitives, the new primitives are already being tested, so I don't need to add anything else for that. What about the documentation? I added the primitives to the API reference. Does it need to be added somewhere else?

[codecov]

Codecov Report

Merging #1948 (2ef3057) into main (9d59bed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1948   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files         146      146           
  Lines       16438    16478   +40     
=======================================
+ Hits        16273    16313   +40     
  Misses        165      165           

Impacted Files	Coverage Δ
...retools/primitives/standard/transform_primitive.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d59bed...2ef3057. Read the comment docs.

[thehomebrewnerd]

@thehomebrewnerd So if I understood correctly, since test_init_and_name fetches all transform primitives, the new primitives are already being tested, so I don't need to add anything else for that. What about the documentation? I added the primitives to the API reference. Does it need to be added somewhere else?

I think adding these to the API reference should be sufficient.

[thehomebrewnerd]

@tvdboom Did you by chance enable github actions to run on your fork of the repo? I am getting dozens of notifications that some of our automated workflows are running and failing on your fork. Unfortunately your forked repo doesn't have the secrets setup for these workflows to succeed and they will continue to fail and send the notifications of the failure.

If actions are enabled, could you please disable them in the settings page?

On another note, I'll take a final look through your PR today, but I think we should be close to approving and merging.

[thehomebrewnerd]

Looks good. Thanks again for the contribution!

[thehomebrewnerd]

@tvdboom Can you please review my message above about the github actions? I am continuing to get dozens of failed action run notices in my email daily about actions failing on your fork of the repo? So far I have not found a way to disable these notifications since they are coming from a repo you own.

Can you please disable actions on your fork of this repo by going to Settings -> Actions -> General in GitHub?